feat: custom key value separator #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caarlos0
reviewed
Sep 28, 2023
|
small comment on the test, other than that looks good to me. Couldn't think of a better name either. |
|
oh, if possible, can you update the readme, too? thank you for the PR btw! 🤘 |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #284 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 460 464 +4
=========================================
+ Hits 460 464 +4
☔ View full report in Codecov by Sentry. |
Separate test for key value separator
Update README.md
ruslan944
force-pushed
the
key-value-separator
branch
from
03dabfd
to
7a141d5
Compare
|
Updates:
|
|
awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have use cases, when we would use ":" as a map value. For example,in the case of "default:http://example.com/," this functionality is currently unavailable due to the ":" character being reserved as a separator between keys and values. This pull request solves the problem.
If you have any suggestions for a more suitable name instead of
envKeyValSeparator, please feel free to share