[Fix rubocop#9523] Fix an error for Style/TrailingMethodEndStatement

Fixes rubocop#9523. This PR fixes an error for `Style/TrailingMethodEndStatement` when endless method definition signature and body are on different lines.
caalberts · Feb 17, 2021 · 8bd7679 · jsx150 · Feb 28, 2021 · 8bd7679
1 parent 787f8b8
commit 8bd7679
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 1 deletion.
diff --git a/changelog/fix_error_for_style_trailing_method_end_statement.md b/changelog/fix_error_for_style_trailing_method_end_statement.md
@@ -0,0 +1 @@
+* [#9523](https://github.com/rubocop-hq/rubocop/issues/9523): Fix an error for `Style/TrailingMethodEndStatement` when endless method definition signature and body are on different lines. ([@koic][])
diff --git a/lib/rubocop/cop/style/trailing_method_end_statement.rb b/lib/rubocop/cop/style/trailing_method_end_statement.rb
@@ -40,7 +40,7 @@ class TrailingMethodEndStatement < Base
               'its own line.'
 
         def on_def(node)
-          return unless trailing_end?(node)
+          return if node.endless? || !trailing_end?(node)
 
           add_offense(node.loc.end) do |corrector|
             corrector.insert_before(

diff --git a/spec/rubocop/cop/style/trailing_method_end_statement_spec.rb b/spec/rubocop/cop/style/trailing_method_end_statement_spec.rb
@@ -122,4 +122,20 @@ def another_method
       end
     RUBY
   end
+
+  context 'when Ruby 3.0 or higher', :ruby30 do
+    it 'does not register an offense when using endless method definition' do
+      expect_no_offenses(<<~RUBY)
+        def foo = bar
+      RUBY
+    end
+
+    it 'does not register an offense when endless method definition signature and body are ' \
+       'on different lines' do
+      expect_no_offenses(<<~RUBY)
+        def foo =
+                  bar
+      RUBY
+    end
+  end
 end