Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for EOL Python 3.4 #79

Merged
merged 2 commits into from Aug 24, 2019
Merged

Drop support for EOL Python 3.4 #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
913db2a
sudo no longer needed https://blog.travis-ci.com/2018-11-19-required-…
hugovk Jul 30, 2019
b254c94
Drop support for EOL Python 3.4
hugovk Jul 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 0 additions & 7 deletions .travis.yml
View file
Open in desktop
@@ -1,13 +1,8 @@
language: python
dist: xenial
# require sudo to avoid Travis falling back to trusty; see
# https://github.com/travis-ci/travis-ci/issues/10110 and also
# https://github.com/travis-ci/travis-ci/issues/9069
sudo: required

python:
- "2.7"
- "3.4"
- "3.5"
- "3.6"
- "3.7"
Expand All @@ -18,10 +13,8 @@ matrix:
include:
- python: "pypy"
dist: trusty
sudo: False
- python: "pypy3"
dist: trusty
sudo: False

install:
- git config --global user.email "bumpversion-test-git@travis.ci"
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Expand Up @@ -16,7 +16,7 @@ RUN pyenv install "$PYPY3_VERSION"

# only install certain versions for tox to use
RUN pyenv versions
RUN pyenv global system 2.7.15 3.4.9 3.5.6 3.6.6 3.7.0 "$PYPY_VERSION" "$PYPY3_VERSION"
RUN pyenv global system 2.7.15 3.5.6 3.6.6 3.7.0 "$PYPY_VERSION" "$PYPY3_VERSION"

RUN git config --global user.email "bumpversion_test@example.org"
RUN git config --global user.name "Bumpversion Test"
Expand Down
3 changes: 0 additions & 3 deletions appveyor.yml
View file
Open in desktop
Expand Up @@ -11,9 +11,6 @@ environment:
- PYTHON: "C:/Python27"
TOXENV: "py27-configparser"

- PYTHON: "C:/Python34"
TOXENV: "py34"

- PYTHON: "C:/Python35"
TOXENV: "py35"

Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Expand Up @@ -27,6 +27,7 @@
'bump2version = bumpversion.cli:main',
]
},
python_requires='>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*',
Copy link

@levrik levrik Aug 27, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm quite new to Python but couldn't that be expressed as >=2.7, <3.0, >=3.5 or >=2.7, <3.0, >3.4?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.python.org/dev/peps/pep-0440/#version-specifiers is a bit vague in this regard. The syntax used here in setup.py appears to be quite common from what I've seen. Perhaps this is just people copying each other though :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

    python_requires=">=2.7, <3.0, >=3.5",

Running pip install -e . on this with Python 3.7 gives:

ERROR: Package 'foo' requires a different Python: 3.7.4 not in '>=2.7, <3.0, >=3.5'

Copy link

@levrik levrik Aug 27, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hugovk Yep. I saw that the , is basically an and.
Also found this: https://packaging.python.org/guides/dropping-older-python-versions/#specify-the-version-ranges-for-supported-python-distributions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a little bit ugly, all the more reason to drop almost-EOL Python 2.7 and write python_requires=">=3.5"!

https://python2woop.pw
https://python3statement.org

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really looking forward to dropping 2.7

classifiers=[
'Development Status :: 4 - Beta',
'Intended Audience :: Developers',
Expand All @@ -36,7 +37,6 @@
'Programming Language :: Python :: 2',
'Programming Language :: Python :: 2.7',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.4',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
@@ -1,5 +1,5 @@
[tox]
envlist = py27, py27-configparser, py34, py35, py36, py37, pypy, pypy3
envlist = py27, py27-configparser, py35, py36, py37, pypy, pypy3

[testenv]
passenv = HOME
Expand Down