Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various warnings when running pytest #46

Merged
merged 15 commits into from
Dec 17, 2018
Merged

Fix various warnings when running pytest #46

merged 15 commits into from
Dec 17, 2018

Conversation

florisla
Copy link
Collaborator

@florisla florisla commented Nov 22, 2018 •
edited

This fixes #44 and silences various warnings and errors related to deprecated methods and text encoding.

It's checked against 2.7, 3.4 and 3.6. Will leave the other versions to CI to check.

ekohl
ekohl reviewed Nov 23, 2018
View reviewed changes
Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I do wonder if we should be making vcs a fixture instead.

@florisla
Copy link
Collaborator Author

I didn't know fixtures could be parametrized as well. It works nicely and I like how much decorators this saves.

Do let me know if the PEP8 cleanup introduces too many changes.

ekohl
ekohl reviewed Nov 23, 2018
View reviewed changes
Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do see a lot xpassed tests in Travis, but don't see exactly which ones. That does worry me cause on Travis they should pass because we have both git and mercurial available.

tests/test_cli.py Outdated Show resolved Hide resolved
@florisla
Copy link
Collaborator Author

florisla commented Nov 23, 2018 •
edited

It's xpassing the exact same tests as when I run 'notgit' instead of 'git' to check for git's presence. Might be related to d7efe91.

@florisla
Copy link
Collaborator Author

florisla commented Nov 23, 2018 •
edited

Still xpassing on git in Travis. I have no clue at this point.

@florisla
Copy link
Collaborator Author

florisla commented Nov 25, 2018 •
edited

I still don't understand why git was reacting differently from hg, but the xpasses are fixed.

@florisla
Check Git/Mercurial presence by calling '--version'
1f14904 
This is a bit faster, but above all produces less verbose output on stdout.
@florisla
Use pytest.param for xfail-marked parameters
2dcc850 
Doing it the old way is deprecated in pytest 4.0 and will produce
errors from pytest >= 4.1.
@florisla
Clean up some unused imports
8912d7d
@florisla
Use logger.warning instead of deprecated logger.warn
e40101e
@florisla
Use config.read_file instead of deprecated read_fp
b790887 
Only when it's available.
It is not available on Python2, if 'configparser' is not installed
(only the stdlib 'ConfigParser').
@florisla
Properly escape or r"rawify" strings with backslashes
46fdc42 
This producing warnings, in particular for '\d'.
@florisla
Upgrade all tests to new [bumpversion:file:filename] syntax
b17b208 
Instead of 'files=file,names'.
This avoids multiple PendingDeprecationWarning when running pytest.
@florisla
Avoid Unicode encoding errors on Windows, also for Python 2
f0b6302 
This was failing in my local Python 2.
@florisla
Avoid Unicode warning in Python 2
d37df5e
@florisla
Fix typo 'is will be deprecated'
9e59054
@florisla
Cosmetic: improve layout of README
6ce9a26
@florisla
Cosmetic: follow PEP8 guidelines
f0fec4e 
Proof that this is useful: I found a bug.
Unit test 'test_non_existing_file' was defined twice so
one of both versions was not being run!

The second one is now called test_non_existing_second_file.
Unit test count went from 140 to 141.
@florisla
Use 'vcs' and 'git' as (parameterized) fixtures
cfb1970 
This saves quite some parametrize() decorators.
@florisla
Make pytest report more context on failed tests by default
f33c91e 
This includes xpassed tests.
Mainly useful for seeing what went wrong in Travis CI.
@florisla
Copy link
Collaborator Author

I squashed some commits and in f33c91e made pytest a bit more verbose on xpassed / xfailed tests.

@florisla
Copy link
Collaborator Author

florisla commented Dec 6, 2018

@c4urself Did you have a chance to look at this?

Currently the Travis badge on https://github.com/c4urself/bump2version is showing "build: failing". Also, new contributors will face Travis failures on their merge requests like in #47.

ekohl
ekohl approved these changes Dec 6, 2018
View reviewed changes
Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Unless @c4urself objects I don't mind merging this.

@florisla florisla mentioned this pull request Dec 7, 2018
Merged
@ekohl ekohl merged commit 038fd6f into c4urself:master Dec 17, 2018
@ekohl
Copy link
Collaborator

ekohl commented Dec 17, 2018

Thanks!

@florisla florisla deleted the pytest-no-warnings branch December 17, 2018 20:51
@kyluca kyluca mentioned this pull request Oct 30, 2019
Closed
@florisla florisla added this to the v1.0.0 milestone Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
cleanup testing
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

Fix deprecation errors on pytest v4.0.x
2 participants
@florisla @ekohl