New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows behavior fixed, with appveyor tests passing #33
Closed
Closed
Changes from 17 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
47b2e7d
appveyor needs strings only in the environment
6db6330
Work correctly when hg is not installed.
ab36633
More gitignore
9f55b5d
Improved error handling
e3ce60f
appveyor needs strings only in the environment
ff6ff8b
Mapping new lines in test_serialize_newline to os.linesep
ed3b17b
Use text mode for io not binary
e795fb7
test_usage_string_fork use bytes
e43ebbb
Replace → with to
eb984a5
Replace → with to (more)
cc48328
Revert "Mapping new lines in test_serialize_newline to os.linesep"
d42354b
Revert "Replace → with to (more)"
a1d8f02
Revert "Replace → with to"
fb6ef2b
For Windows and py2, encode unicode before calling subprocess
16f040c
Addressing encoding in test_usage_string_fork
8af3125
Revert "Addressing encoding in test_usage_string_fork"
3f781ba
xfailing problem case on WIndows PY3
8dbaf48
Different approach to the encoding issue in the help
b6fe568
oops missed one
29769c7
Moving windows/PY3 tag message from test into main code base
8379713
Revert "Moving windows/PY3 tag message from test into main code base"
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a
universal_lines
parameter which also fixes encoding issues. Perhaps that'd remove the need forxfail
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it's
universal_newlines
FWIW