Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix issue 22 new version #31

Closed

Conversation

jeremycarroll
Copy link
Contributor

@jeremycarroll jeremycarroll commented Aug 19, 2018

This addresses part should not be required if supplying --new-version #22.

Notice:

  • it is backwardly incompatible, since the bug is with the command line API not the implementation of the API: this might merit a 0.6.0 version number.
  • the tests change to reflect the change in API
  • the implementation is short and direct but somewhat dirty, inspecting the argument list for --new-version directly. I find the cascade of ArgumentParsers unattractive, and this fix makes it marginally worse in my view.

Fixes #22

@ekohl
Copy link
Collaborator

ekohl commented Aug 29, 2018

You can ignore appveyor for now. #34 should fix that.

@jeremycarroll
Copy link
Contributor Author

jeremycarroll commented Aug 29, 2018

My plan is to wait for #34 to be merged, and then merge it into this

@ekohl
Copy link
Collaborator

ekohl commented Aug 29, 2018

Now that it's merged, would you mind rebasing?

@c4urself
Copy link
Owner

Let's rebase and merge this in and I'll cut a new release.

@jeremycarroll
Copy link
Contributor Author

I am not working on this, and do not envisage doing so in the next two to three years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

part should not be required if supplying --new-version
3 participants