New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make readme readable on pypi #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be ok with this but note that to release you need recents version of tools that understand this metadata.
setup.py
Outdated
@@ -19,6 +15,7 @@ | |||
packages=['bumpversion'], | |||
description=description, | |||
long_description=long_description, | |||
long_description_content_type="text/markdown" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're missing a comma at the end here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
snap, your right
r"\1", | ||
str(open('README.md', 'rb').read()).replace(description, '') | ||
) | ||
with open('README.md', 'UTF-8') as readme: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks on Python 3 with ValueError: invalid mode: 'UTF-8'
, see the Travis run.
I think this can be closed now that #26 is merged. |
No description provided.