Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug: part optional value is not used when parent part is bumped #186

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix bug: part optional value is not used when parent part is bumped #186

wants to merge 5 commits into from

Conversation

florisla
Copy link
Collaborator

Fixes #134

@florisla
Allow serialization without a specified context
626cf0f 
This makes the upcoming unit test a little shorter.
@florisla
Add unit test for bug 134
37857f5
@florisla
Fix 134: copy VersionPart config in copy()
bbaeadd 
This way, the optional_value can be used when required.
@florisla
Cleanup: simplify code a bit
c911dd0
@florisla
Docs: Clarify that first serialize should be complete
ca29428 
If you reverse the order, funny behavior ensues.
@florisla florisla added this to the release-v{next} milestone Jan 18, 2021
mbromell
mbromell approved these changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@mbromell mbromell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test looks good, works as expected.
I also did a manual test just to be sure, I was having this same issue the bug describes, this fixed it.

@florisla
Copy link
Collaborator Author

Thanks for looking at this!

This should definitely make it into the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbromell mbromell mbromell approved these changes

Assignees
No one assigned
Labels
bug requires-review
Projects
None yet
Milestone
Next release
Development

Successfully merging this pull request may close these issues.

Build result in 0.0.0-01 instead of 0.0.0-dev1
2 participants
@florisla @mbromell