Test through docker image (CircleCI) #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making use of the same tox-base image that's used in the current Dockerfile.
Also drop Python 3.4 as in the other CI configs. Source of the Python versions: https://github.com/themattrix/docker-tox-base/blob/master/python-versions.txt
This way the CI will not fail on missing Python versions when upstream updates the dockerfile.
florisla
changed the title
|
Have you considered Github Actions as well? There's tox-gh-actions similar to tox-travis. GH actions also has Windows support so we could unify all CI that way. |
|
I'm not familiar with GitHub actions. It looks interesting but currently I lack the time to dive in. Closing this for now; we can always revisit later if required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #49 there was some talk about doing CI testing of bump2version using Docker images.
This PR adds a config file for CircleCI, which is a service which does exactly that.
It uses the same docker images as the regular Dockerfile.
This has the potential to replace Travis (not AppVeyor which covers Windows support).