New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for EOL Python 3.4 #79
Conversation
@@ -27,6 +27,7 @@ | |||
'bump2version = bumpversion.cli:main', | |||
] | |||
}, | |||
python_requires='>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm quite new to Python but couldn't that be expressed as >=2.7, <3.0, >=3.5
or >=2.7, <3.0, >3.4
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://www.python.org/dev/peps/pep-0440/#version-specifiers is a bit vague in this regard. The syntax used here in setup.py appears to be quite common from what I've seen. Perhaps this is just people copying each other though :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python_requires=">=2.7, <3.0, >=3.5",
Running pip install -e .
on this with Python 3.7 gives:
ERROR: Package 'foo' requires a different Python: 3.7.4 not in '>=2.7, <3.0, >=3.5'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hugovk Yep. I saw that the ,
is basically an and
.
Also found this: https://packaging.python.org/guides/dropping-older-python-versions/#specify-the-version-ranges-for-supported-python-distributions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a little bit ugly, all the more reason to drop almost-EOL Python 2.7 and write python_requires=">=3.5"
!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really looking forward to dropping 2.7
Python 3.4 is EOL and no longer receiving security updates (or any updates) from the core Python team.
Source: https://en.wikipedia.org/wiki/CPython#Version_history
It's also little used. Here's the pip installs for bump2version from PyPI for June 2019:
Source:
pypistats python_minor bump2version --last-month # pip install pypistats