Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for EOL Python 3.4 #79

Merged
merged 2 commits into from Aug 24, 2019
Merged

Drop support for EOL Python 3.4 #79

merged 2 commits into from Aug 24, 2019

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Jul 30, 2019

Python 3.4 is EOL and no longer receiving security updates (or any updates) from the core Python team.

Version Release date Supported until
2.7 2010-07-03 2020-01-01
3.4 2014-03-16 2019-03-16

Source: https://en.wikipedia.org/wiki/CPython#Version_history

It's also little used. Here's the pip installs for bump2version from PyPI for June 2019:

category percent downloads
3.6 42.42% 5,873
3.7 32.22% 4,460
2.7 15.17% 2,100
3.5 6.06% 839
3.4 2.14% 296
null 1.54% 213
3.8 0.39% 54
3.3 0.07% 9
Total 13,844

Source: pypistats python_minor bump2version --last-month # pip install pypistats

@c4urself c4urself closed this Aug 24, 2019
@c4urself c4urself reopened this Aug 24, 2019
@c4urself c4urself merged commit af8871e into c4urself:master Aug 24, 2019
@hugovk hugovk deleted the rm-3.4 branch August 24, 2019 20:02
@@ -27,6 +27,7 @@
'bump2version = bumpversion.cli:main',
]
},
python_requires='>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*',
Copy link

@levrik levrik Aug 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm quite new to Python but couldn't that be expressed as >=2.7, <3.0, >=3.5 or >=2.7, <3.0, >3.4?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.python.org/dev/peps/pep-0440/#version-specifiers is a bit vague in this regard. The syntax used here in setup.py appears to be quite common from what I've seen. Perhaps this is just people copying each other though :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

    python_requires=">=2.7, <3.0, >=3.5",

Running pip install -e . on this with Python 3.7 gives:

ERROR: Package 'foo' requires a different Python: 3.7.4 not in '>=2.7, <3.0, >=3.5'

Copy link

@levrik levrik Aug 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a little bit ugly, all the more reason to drop almost-EOL Python 2.7 and write python_requires=">=3.5"!

https://python2woop.pw
https://python3statement.org

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really looking forward to dropping 2.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants