Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Announce support for Python 3.7 #49

Merged
merged 2 commits into from Jan 10, 2019
Merged

Conversation

florisla
Copy link
Collaborator

bump2version does not mention Python v3.7 support on PyPI, even though it works fine without any changes.

This commit adds the classifier Programming Language :: Python :: 3.7 and tells Travis/Tox/AppVeyor to test against 3.7 too.

.travis.yml Outdated
include:
- python: 3.7
dist: xenial
sudo: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this need sudo?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's due to this Travis oddity: travis-ci/travis-ci#10110 .

.travis.yml Outdated
matrix:
include:
- python: 3.7
dist: xenial
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind moving the entire matrix to xenial. That should still support all the python versions.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently Travis xenial does not support regular pypy / pypy3; I've kept those on trusty. Relevant issue is https://travis-ci.community/t/pypy-2-7-on-xenial/889 .

@c4urself
Copy link
Owner

c4urself commented Dec 30, 2018

In future, we should also be bumping the Dockerfile as part of this, (this was put in place so people can run the test suite on all versions locally via make test). I've already added the change for 3.7 to be installed here: 5f6d8f7 so the PRs are perfectly compatible.

Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the effort!

@florisla
Copy link
Collaborator Author

florisla commented Jan 3, 2019

I've documented the pypy-on-trusty and sudo-on-xenial oddities in .travis.yml itself.

@c4urself
Copy link
Owner

c4urself commented Jan 3, 2019

I wonder if Travis let's you just run some Docker containers? If so, we may be able to bring make test into .travis.yml and make testing a bit more consistent?

@florisla
Copy link
Collaborator Author

florisla commented Jan 9, 2019

Rebased on master.

Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can run docker containers on Travis, but I'd prefer to avoid that unless we have to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants