-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Announce support for Python 3.7 #49
Conversation
.travis.yml
Outdated
include: | ||
- python: 3.7 | ||
dist: xenial | ||
sudo: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this need sudo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's due to this Travis oddity: travis-ci/travis-ci#10110 .
.travis.yml
Outdated
matrix: | ||
include: | ||
- python: 3.7 | ||
dist: xenial |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind moving the entire matrix to xenial. That should still support all the python versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently Travis xenial does not support regular pypy / pypy3; I've kept those on trusty. Relevant issue is https://travis-ci.community/t/pypy-2-7-on-xenial/889 .
In future, we should also be bumping the Dockerfile as part of this, (this was put in place so people can run the test suite on all versions locally via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the effort!
I've documented the pypy-on-trusty and sudo-on-xenial oddities in |
I wonder if Travis let's you just run some Docker containers? If so, we may be able to bring |
Except pypy/pypy3 - keep those on trusty due to https://travis-ci.community/t/pypy-2-7-on-xenial/889 .
Rebased on master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can run docker containers on Travis, but I'd prefer to avoid that unless we have to.
bump2version does not mention Python v3.7 support on PyPI, even though it works fine without any changes.
This commit adds the classifier
Programming Language :: Python :: 3.7
and tells Travis/Tox/AppVeyor to test against 3.7 too.