unit test for download module #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rebaseコマンド叩きましたか？ Files Changedが見えづらいので、最新のmainからrebasdを叩いてください |
To-Ki-O
force-pushed
the
feature/test-download
branch
from
413aae9
to
c780831
Compare
|
失礼いたしました。 リベースいたしましたので、ご確認よろしくお願いします。 |
|
@To-Ki-O すいませんが、あと最終的な実行手順ももらえますか？ |
|
承知しました。
この手順でテストを実行できます。 |
|
上記の手順は詳細ドキュメントに追加しておきましょうか。 |
ryo-ma
reviewed
Mar 27, 2023
ryo-ma
reviewed
Mar 27, 2023
ryo-ma
reviewed
Mar 27, 2023
|
こちらのコマンドを実行すると以下のように no tests run になりますが何かわかりますでしょうか？ |
|
#35 (comment) |
|
Slackのコードをそのまま掲載してしまい、すいませんでした。 手順通りであれば、 CKAN_SQLALCHEMY_URL= CKAN_DATASTORE_READ_URL= CKAN_DATASTORE_WRITE_URL= pytest -s --ckan-ini=config/test.ini --cov=ckanext.feedback --cov-branch --disable-warnings ./※ #35 (comment)で指摘いただいたコードと同様になります |
ryo-ma
reviewed
Mar 27, 2023
ryo-ma
reviewed
Mar 27, 2023
ryo-ma
reviewed
Mar 27, 2023
To-Ki-O
force-pushed
the
feature/test-download
branch
from
0cb5f27
to
c533eb4
Compare
To-Ki-O
added a commit
that referenced
this pull request
Mar 29, 2023
* initial commit to do test * modify test.ini and test_download.py in models * move test.ini from root to ckanext/feedback/tests * delete sections that is not needed * delete test.init and modify config/test.ini * add DownloadSummary model test * modify indents in download model test * add download controller test * add test about download service * delete test about download model * commit to checkout * change to use the mock of database access * commit to checkout * commit to checkout * commit to checkout * rewrite the test to use test DB * run isort, black, pflake8 * rename views to services * delete DownloadController.increment_resource_download * delete app_context * sepalate the test of extended_download * modify static initializaer to setup_class * add setup function and move resource and app into it * change setup to setup_method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
フィードバック機能のダウンロードモジュールに関する単体テストを作成しました。
よろしくお願いします。