-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flatten TF module structure via .tfvars
/.tfbackend
, update to TF v1.5.3
#980
base: dev
Are you sure you want to change the base?
Conversation
a8bdd8d
to
2f0e09c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This module restructuring clobbers the existing state, but I don't really want to fill up the template with a bunch of |
As an example of how to use these environments, navigate to the
If you then try switch to production (not that you should really be doing that outside of CI/CD), the CLI will instruct you to call
|
… local backend This makes it harder to do the wrong thing. With this change, we avoid a potential footgun when developers use `terraform init` instead of `terraform init -backend-config=dev.s3.tfbackend`. This isn't a functional change because we were already using encryption on everything in our state buckets.
dd4d37a
to
7602118
Compare
Rebased on |
@jvisker have we talk about this in the cloud guild yet? Are we still discussing it? Do we need to update an ADR before merging? |
Docs needed to be updated either way. I know we've done some bikeshedding on the directory name before. I didn't previously care whether it was called terraform/, iac/, terraform-iac/ or anything else. Nowadays, I have a tiny reason to prefer the name terraform/: it plays nicely with automatic folder icons. The other options don't.
Updated docs. That needed to happen. Also renamed |
Another tiny reason to rename |
# Conflicts: # .github/workflows/ci-iac.yml # .github/workflows/deploy.yml # terraform-iac/cpy/app/cpy-app.tf # terraform-iac/cpy/setup/.terraform.lock.hcl # terraform-iac/cpy/setup/cpy-setup.tf # terraform-iac/dev/app/.terraform.lock.hcl # terraform-iac/dev/app/dev-app.tf # terraform-iac/dev/setup/.terraform.lock.hcl # terraform-iac/dev/setup/dev-setup.tf # terraform-iac/prd/app/.terraform.lock.hcl # terraform-iac/prd/app/prd-app.tf # terraform-iac/prd/setup/prd-setup.tf # terraform-iac/stg/app/.terraform.lock.hcl # terraform-iac/stg/app/stg-app.tf # terraform-iac/stg/setup/.terraform.lock.hcl # terraform-iac/stg/setup/stg-setup.tf # terraform/app/.terraform.lock.hcl # terraform/setup/.terraform.lock.hcl
Using
.tfvars
and.tfbackend
files, we can flatten our TF modules.