Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GHA caching built into Docker Buildx #272

Merged
merged 1 commit into from Jul 20, 2021
Merged

Conversation

GaryGSC
Copy link
Member

@GaryGSC GaryGSC commented Jul 20, 2021

The Docker actions can now natively use the GitHub Actions cache, though things haven't quite gotten through the release pipeline.

This should work as-is, but once things have been released, we'll no longer need to explicitly use v0.6.0 of Buildx.

Using docker/build-push-action@v2 in CI allows us to get rid of

with:
  install: true

If someone using this template were to build multiple Docker images, they'd want to specify a scope to avoid cache collision/invalidation.

@github-actions
Copy link

Terraform Plan:

will create 1 resource:

  • local_file - appspec_json

will update 2 resources:

  • aws_s3_bucket - my_s3_bucket_logs
  • aws_lambda_function - test_lambda

will replace (delete then create) 1 resource:

  • aws_ecs_task_definition - task_def

see details

@GaryGSC
Copy link
Member Author

GaryGSC commented Jul 20, 2021

This repo has a pretty small Dockerfile, so the effects aren't very pronounced, but here are the stats:

Supposedly, the time to set up Buildx should go down once a little once it's natively available in the GitHub runner, but it seems basically identical already.

@GaryGSC GaryGSC requested a review from a team July 20, 2021 14:50
@GaryGSC GaryGSC merged commit 0d86fdc into dev Jul 20, 2021
@GaryGSC GaryGSC deleted the setup-buildx-action-cache branch July 20, 2021 17:55
This was referenced Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants