Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change newline character #34

Merged
merged 4 commits into from
Sep 8, 2020
Merged

Change newline character #34

merged 4 commits into from
Sep 8, 2020

Conversation

blakemorgan
Copy link

This comment suggested that this will fix the multiline string in CloudWatch. I don't know how to test it other than by deploying it.

  • Change newline character
  • Bump version

@GaryGSC
Copy link
Member

GaryGSC commented Sep 8, 2020

I don't know how to test it other than by deploying it.

You should be able to deploy this change (without us needing to merge this PR) by replacing "byu-jwt": "^3.0.3" with "byu-jwt": "blakemorgan/byu-jwt-nodejs#newline" in your package.json.

CI is failing because your fork doesn't have access to the GitHub Secrets. I can make a branch here to try out CI.

@blakemorgan
Copy link
Author

@GaryGSC Great thanks. I will give that a try and continue to tweak it until it works. I'll let you know once I've confirmed these changes have the desired outcome.

@GaryGSC GaryGSC mentioned this pull request Sep 8, 2020
@blakemorgan
Copy link
Author

@GaryGSC I got it working. Can you run the CI again and, if you're OK with the changes, do the merge and release?
Screen Shot 2020-09-08 at 2 15 23 PM

@GaryGSC GaryGSC merged commit c720249 into byu-oit:master Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants