Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to decode u64 or i64 slice in native c #455

Draft
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

hhu-dc
Copy link

@hhu-dc hhu-dc commented Jun 12, 2023

goIntSlice.c是写的函数文件
单元测试暂时还没来得及弄
用main函数自己手动测试的

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@b40bbd5). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #455   +/-   ##
=======================================
  Coverage        ?   77.95%           
=======================================
  Files           ?       63           
  Lines           ?    10420           
  Branches        ?        0           
=======================================
  Hits            ?     8123           
  Misses          ?     1944           
  Partials        ?      353           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@liuq19
Copy link
Collaborator

liuq19 commented Jun 12, 2023

一些 comments:

  1. 代码一般不要使用中文注释
  2. 不要使用hard-code,char 字符可以直接用'0', '1' ,没必要用整数例如60, 61
  3. 简化嵌套循环,能用一个循环解决的,不要使用嵌套while
  4. 代码括号要对齐,空格要对齐。

@liuq19
Copy link
Collaborator

liuq19 commented Jun 12, 2023

注意pr title 和 commit msg,可以参考sonic 已有的pr 和 commit

@hhu-dc
Copy link
Author

hhu-dc commented Jun 25, 2023

1.把注释改成了英文
2.解决了hard-code问题
3.随时是循环嵌套了一次while ,但是实际上复杂度只有o(n),本质上只便利了一次
4.括号空格已经对齐
5.修改了单元测试代码

@hhu-dc hhu-dc closed this Jun 25, 2023
@hhu-dc hhu-dc reopened this Jun 25, 2023
@hhu-dc hhu-dc changed the title test_goIntSlice to decode u64 or i64 slice in native c Jun 25, 2023
native/goIntSlice.c Outdated Show resolved Hide resolved
native/goIntSlice.c Outdated Show resolved Hide resolved
native/goIntSlice.c Outdated Show resolved Hide resolved
native/goIntSlice.c Outdated Show resolved Hide resolved
native/unittest/unittest_goIntSlice.c Outdated Show resolved Hide resolved
native/goIntSlice.c Outdated Show resolved Hide resolved
native/unittest/test_goIntSlice.c Outdated Show resolved Hide resolved
native/goIntSlice.c Outdated Show resolved Hide resolved
native/goIntSlice.c Outdated Show resolved Hide resolved
native/unittest/unittest_goIntSlice.c Outdated Show resolved Hide resolved
native/goIntSlice.c Outdated Show resolved Hide resolved
native/goIntSlice.c Outdated Show resolved Hide resolved
native/goIntSlice.c Outdated Show resolved Hide resolved
native/goIntSlice.c Outdated Show resolved Hide resolved
native/goIntSlice.c Outdated Show resolved Hide resolved
native/goIntSlice.c Outdated Show resolved Hide resolved
native/goIntSlice.c Outdated Show resolved Hide resolved
native/goIntSlice.c Outdated Show resolved Hide resolved
native/goIntSlice.c Outdated Show resolved Hide resolved
native/goIntSlice.c Outdated Show resolved Hide resolved
native/goIntSlice.c Outdated Show resolved Hide resolved
native/goIntSlice.c Outdated Show resolved Hide resolved
native/goIntSlice.c Outdated Show resolved Hide resolved
native/goIntSlice.c Outdated Show resolved Hide resolved
native/goIntSlice.c Outdated Show resolved Hide resolved
native/goIntSlice.c Outdated Show resolved Hide resolved
native/goIntSlice.c Outdated Show resolved Hide resolved
liuq19
liuq19 previously approved these changes Jul 1, 2023
Copy link
Collaborator

@liuq19 liuq19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, LGTM

@CLAassistant
Copy link

CLAassistant commented Jul 13, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ liuq19
❌ hhu-dc
You have signed the CLA already but the status is still pending? Let us recheck it.

@AsterDY AsterDY marked this pull request as draft January 24, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants