Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: the get&set way of hashmap using xxhash #454

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

lijinnan123
Copy link

I have changed the Chinese to English.

@liuq19
Copy link
Collaborator

liuq19 commented Jun 12, 2023

Thanks, we do not need to open a new pr for this. We can use the previous pr such as #453 , and push all commits into the single branch~

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@3ed2c48). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #454   +/-   ##
=======================================
  Coverage        ?   77.92%           
=======================================
  Files           ?       63           
  Lines           ?    10418           
  Branches        ?        0           
=======================================
  Hits            ?     8118           
  Misses          ?     1947           
  Partials        ?      353           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@liuq19
Copy link
Collaborator

liuq19 commented Jun 13, 2023

We should follow https://github.com/bytedance/sonic/blob/main/CONTRIBUTING.md, pls rename the pr title and reedit the commit msg, such as opt: the get&set way of hashmap using xxhash

Also, please add the xxhash license into licenses/ directory.

@liuq19 liuq19 changed the title Test/ljn opt: the get&set way of hashmap using xxhash Jun 25, 2023
native/native.h Outdated Show resolved Hide resolved
native/unittest/test_hashgetset.c Outdated Show resolved Hide resolved
native/hashmap_set.c Outdated Show resolved Hide resolved
native/hashmap_get.c Outdated Show resolved Hide resolved
liuq19
liuq19 previously approved these changes Jun 28, 2023
Copy link
Collaborator

@liuq19 liuq19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

liuq19
liuq19 previously approved these changes Jun 29, 2023
Copy link
Collaborator

@liuq19 liuq19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lijinnan123
Copy link
Author

Thanks! Good luck to my teacher!

@liuq19
Copy link
Collaborator

liuq19 commented Jul 3, 2023

Thanks~

@CLAassistant
Copy link

CLAassistant commented Jul 13, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ liuq19
❌ lijinnan123
You have signed the CLA already but the status is still pending? Let us recheck it.

@AsterDY AsterDY marked this pull request as draft January 24, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants