New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opt: the get&set way of hashmap using xxhash #454
base: main
Are you sure you want to change the base?
Conversation
Thanks, we do not need to open a new pr for this. We can use the previous pr such as #453 , and push all commits into the single branch~ |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #454 +/- ##
=======================================
Coverage ? 77.92%
=======================================
Files ? 63
Lines ? 10418
Branches ? 0
=======================================
Hits ? 8118
Misses ? 1947
Partials ? 353 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
We should follow https://github.com/bytedance/sonic/blob/main/CONTRIBUTING.md, pls rename the pr title and reedit the commit msg, such as Also, please add the xxhash license into |
…test/ljn Some changes happened in these two weeks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
Thanks! Good luck to my teacher! |
Thanks~ |
|
I have changed the Chinese to English.