Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check mismatch error after recursive #407

Merged
merged 3 commits into from May 6, 2023
Merged

fix: check mismatch error after recursive #407

merged 3 commits into from May 6, 2023

Conversation

liuq19
Copy link
Collaborator

@liuq19 liuq19 commented Apr 26, 2023

Fixed #406 .

To support skipped mismatched-type JSON value in decoding as encoding/json. (relative PR #325 )

@liuq19
Copy link
Collaborator Author

liuq19 commented Apr 27, 2023

performance:

cpu: Intel(R) Xeon(R) Platinum 8260 CPU @ 2.40GHz
                                         │ /tmp/tmp74zg0lnz.source.txt │    /tmp/tmpiswozcyw.target.txt     │
                                         │           sec/op            │   sec/op     vs base               │
UnmarshalConcrete/CanadaGeometry_Sonic-8                   1.039m ± 3%   1.026m ± 3%       ~ (p=0.436 n=10)
UnmarshalConcrete/CitmCatalog_Sonic-8                      5.999m ± 3%   5.904m ± 5%       ~ (p=0.315 n=10)
UnmarshalConcrete/GolangSource_Sonic-8                     15.40m ± 7%   16.42m ± 4%  +6.66% (p=0.001 n=10)
UnmarshalConcrete/StringEscaped_Sonic-8                    88.04µ ± 5%   88.14µ ± 5%       ~ (p=0.684 n=10)
UnmarshalConcrete/StringUnicode_Sonic-8                    10.18µ ± 8%   10.58µ ± 6%       ~ (p=0.271 n=10)
UnmarshalConcrete/SyntheaFhir_Sonic-8                      11.67m ± 5%   11.47m ± 5%       ~ (p=0.481 n=10)
UnmarshalConcrete/TwitterStatus_Sonic-8                    2.411m ± 4%   2.315m ± 5%  -3.98% (p=0.015 n=10)
geomean                                                    1.135m        1.137m       +0.25%

                                         │ /tmp/tmp74zg0lnz.source.txt │     /tmp/tmpiswozcyw.target.txt     │
                                         │             B/s             │     B/s       vs base               │
UnmarshalConcrete/CanadaGeometry_Sonic-8                  248.3Mi ± 3%   251.3Mi ± 2%       ~ (p=0.436 n=10)
UnmarshalConcrete/CitmCatalog_Sonic-8                     274.6Mi ± 3%   279.1Mi ± 4%       ~ (p=0.315 n=10)
UnmarshalConcrete/GolangSource_Sonic-8                    120.2Mi ± 7%   112.7Mi ± 4%  -6.24% (p=0.001 n=10)
UnmarshalConcrete/StringEscaped_Sonic-8                   455.6Mi ± 5%   455.1Mi ± 5%       ~ (p=0.684 n=10)
UnmarshalConcrete/StringUnicode_Sonic-8                   1.657Gi ± 8%   1.595Gi ± 7%       ~ (p=0.280 n=10)
UnmarshalConcrete/SyntheaFhir_Sonic-8                     164.1Mi ± 5%   167.0Mi ± 5%       ~ (p=0.481 n=10)
UnmarshalConcrete/TwitterStatus_Sonic-8                   249.8Mi ± 4%   260.1Mi ± 5%  +4.14% (p=0.015 n=10)
geomean                                                   307.5Mi        306.7Mi       -0.25%

@liuq19 liuq19 merged commit ebbe758 into bytedance:main May 6, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unmarshal wrong slice in map not as encoding/json
2 participants