Skip to content

Commit

Permalink
fix: incorrectly handle alias type of pointer in struct (#404)
Browse files Browse the repository at this point in the history
  • Loading branch information
AsterDY committed Apr 19, 2023
1 parent 869fa1b commit cdd8937
Show file tree
Hide file tree
Showing 2 changed files with 53 additions and 1 deletion.
2 changes: 1 addition & 1 deletion internal/resolver/resolver.go
Expand Up @@ -152,8 +152,8 @@ func resolveFields(vt reflect.Type) []FieldMeta {
}

/* get the index to the last offset */
fvt := fv.typ
idx := len(path) - 1
fvt := path[idx].Type

/* do not dereference into fields */
if path[idx].Kind == F_deref {
Expand Down
52 changes: 52 additions & 0 deletions issue_test/issuex403_test.go
@@ -0,0 +1,52 @@
/**
* Copyright 2023 ByteDance Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package issue_test

import (
`encoding/json`
`testing`

`github.com/bytedance/sonic`
`github.com/stretchr/testify/require`
)

type Issue403 struct {
Card PtrAlias `json:"card"`
}

type PtrAlias *MarshalerImpl

type MarshalerImpl struct{
A int
}

func (self *MarshalerImpl) MarshalJSON() ([]byte, error) {
return []byte("1"), nil
}

func TestIssue403(t *testing.T) {
obj := MarshalerImpl{0}
messageInfo := &Issue403{
Card: &obj,
}

jsonData, err := json.Marshal(messageInfo)
require.NoError(t, err)
sonicData, err := sonic.Marshal(messageInfo)
require.NoError(t, err)
require.Equal(t, jsonData, sonicData)
}

0 comments on commit cdd8937

Please sign in to comment.