Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use monoio on stable. #227

Merged
merged 3 commits into from Jan 30, 2024
Merged

Allow to use monoio on stable. #227

merged 3 commits into from Jan 30, 2024

Conversation

gz
Copy link
Contributor

@gz gz commented Jan 21, 2024

There were only a few nightly features left in the code-base so this code changes monoio so it can be compiled on stable too.

Also adds a unstable feature flag that preserves the nightly-only code paths for easier migration in the future.

Fixes #129

Also adds a unstable feature flag that preserves the nightly-only code
paths for easier migration in the future.

Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
@CLAassistant
Copy link

CLAassistant commented Jan 21, 2024

CLA assistant check
All committers have signed the CLA.

rust-toolchain Outdated Show resolved Hide resolved
Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
@gz
Copy link
Contributor Author

gz commented Jan 24, 2024

I have also adjusted the README, but probably README-zh.md needs to be adjusted too.

@ihciah ihciah merged commit 4aa1dc6 into bytedance:master Jan 30, 2024
5 of 6 checks passed
@ihciah
Copy link
Member

ihciah commented Jan 30, 2024

In thread.rs the LazyLock is used. It seems break the compiling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stable Rust now that GATs are stable?
3 participants