feat: support handle events order by sender #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiankunli
force-pushed
the
feat/make-sure-event-order
branch
from
01af2eb
to
6e70fd9
Compare
ealyn
reviewed
Apr 28, 2024
qiankunli
force-pushed
the
feat/make-sure-event-order
branch
from
6e70fd9
to
d8384d7
Compare
yeehomfoo
reviewed
Apr 28, 2024
eventbus/mysql/eventbus.go
Outdated
|
|
||
| // 按EventCreatedAt 排序 | ||
| sort.Sort(ByEventCreatedAt(eventPOs)) | ||
| // 按sender分组 |
There was a problem hiding this comment.
是否应该有个开关，如果业务场景大量事件sender相同，并发消费会失效。框架之前有设计事件发送类型，可以考虑实现SendTypeFIFO（保序事件）
There was a problem hiding this comment.
SendTypeFIFO定义：
Line 38 in eb0f0ef
ealyn
reviewed
Apr 28, 2024
eventbus/mysql/eventbus.go
Outdated
| senderEvents[e.Event.GetSender()] = append(_events, e) | ||
| } | ||
| events := make(chan []*EventPO, len(senderEvents)) | ||
| for _, _events := range senderEvents { |
There was a problem hiding this comment.
ByEventCreatedAt用基数排序实现，把sender也纳入排序，就不用搞个map中间变量了
yeehomfoo
reviewed
Apr 28, 2024
eventbus/mysql/eventbus_test.go
Outdated
|
|
||
| func TestSortEvent(t *testing.T) { | ||
| e1 := &EventPO{Event: &dddfirework.DomainEvent{Sender: "1"}, EventCreatedAt: time.Now()} | ||
| time.Sleep(1 * time.Millisecond) |
There was a problem hiding this comment.
不建议在ut里sleep，可通过计算实现，比如：time.Now().Add(1 * time.Millisecond)
qiankunli
force-pushed
the
feat/make-sure-event-order
branch
from
d8384d7
to
c19ce1c
Compare
yeehomfoo
reviewed
Apr 28, 2024
eventbus/mysql/eventbus.go
Outdated
| @@ -423,11 +424,33 @@ func (e *EventBus) doRetryStrategy(service *ServicePO, remainIDs, failedIDs []in | |||
| } | |||
|
|
|||
| func (e *EventBus) dispatchEvents(ctx context.Context, eventPOs []*EventPO) (failed, panics []int64) { | |||
| events := make(chan *EventPO, len(eventPOs)) | |||
|
|
|||
| // 按EventCreatedAt 排序 | |||
There was a problem hiding this comment.
只有FIFO事件需要排序，FIFO不一定是主要场景，是否不对所有事件排序而是只对需要排序的事件排序？另外，考虑是否考虑sql查询的时候直接排序，只对limit结果做排序的话全局是否仍然会出现乱序
qiankunli
force-pushed
the
feat/make-sure-event-order
branch
from
c19ce1c
to
c2145b3
Compare
qiankunli
force-pushed
the
feat/make-sure-event-order
branch
from
c2145b3
to
7be8efa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.