fix: remove big transaction in handleEvents #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiankunli
force-pushed
the
fix/remove-big-transaction
branch
2 times, most recently
from
2ba15e0
to
deff899
Compare
|
引入lock/db有点捆绑的意思了，我倾向于拆开成一个event一个transaction，也能改进并发 |
引入lock db的意思主要是 保证多实例下只有一个实例 可以执行handleevent 逻辑。 |
qiankunli
force-pushed
the
fix/remove-big-transaction
branch
2 times, most recently
from
a057178
to
6ef9e2d
Compare
qiankunli
force-pushed
the
fix/remove-big-transaction
branch
from
6ef9e2d
to
50bd2c4
Compare
yeehomfoo
reviewed
Apr 15, 2024
| @@ -155,6 +156,7 @@ type EventBus struct { | |||
|
|
|||
| cb dddfirework.DomainEventHandler | |||
| cleanCron *cron.Cron | |||
| lock *lockdb.DBLock | |||
There was a problem hiding this comment.
这个感觉强制绑定dblock了，一定需要引入个dblock么
qiankunli
force-pushed
the
fix/remove-big-transaction
branch
from
50bd2c4
to
e1ab495
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.