fix(ddd): fix mysql diff with json #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archever
force-pushed
the
ljh/fix-diff
branch
3 times, most recently
from
f60ad9e
to
c5f3f92
Compare
kirinzhong
reviewed
Mar 12, 2024
| if entity.GetID() == "" && parent.GetID() == "" { | ||
| return fmt.Errorf("entity to build must has id") | ||
| } | ||
| // if entity.GetID() == "" && parent.GetID() == "" { |
There was a problem hiding this comment.
上游传的 parent 是 nil, 这里会报错. parent 和 entity 的关系是通过 parentID. 关联的, 所以 entity 这里是没有ID 的
liqiankun1111
approved these changes
May 20, 2024
liqiankun1111
added a commit
that referenced
this pull request
May 20, 2024
This reverts commit 335d1a7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix update entity while no field changed