Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy through the URI authority unmodified to Host #8563

Merged
merged 1 commit into from
May 6, 2024

Conversation

elliottt
Copy link
Member

@elliottt elliottt commented May 6, 2024

Rather than construct an authority that includes the default port for the scheme given, copy the authority through. This better matches the behavior in the http/1.1 spec, as pointed out in #8430.

Fixes #8430

@elliottt elliottt requested a review from a team as a code owner May 6, 2024 21:57
@elliottt elliottt requested review from alexcrichton and removed request for a team May 6, 2024 21:57
@elliottt elliottt changed the title Copy through the authority unmodified to Host Copy through the URI authority unmodified to Host May 6, 2024
@alexcrichton alexcrichton added this pull request to the merge queue May 6, 2024
Merged via the queue into bytecodealliance:main with commit 962a7fa May 6, 2024
22 checks passed
alexcrichton pushed a commit to alexcrichton/wasmtime that referenced this pull request May 7, 2024
alexcrichton added a commit that referenced this pull request May 7, 2024
Fixes #8430

Co-authored-by: Trevor Elliott <telliott@fastly.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wasmtime-wasi-http shouldn't add the default port to outbound host header
3 participants