Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typos in comments #8495

Merged
merged 4 commits into from Apr 29, 2024
Merged

typos in comments #8495

merged 4 commits into from Apr 29, 2024

Conversation

FrankReh
Copy link
Contributor

No description provided.

@FrankReh FrankReh requested a review from a team as a code owner April 27, 2024 10:30
@FrankReh FrankReh requested review from fitzgen and removed request for a team April 27, 2024 10:30
@github-actions github-actions bot added the wasmtime:api Related to the API of the `wasmtime` crate itself label Apr 27, 2024
@FrankReh
Copy link
Contributor Author

Assume if some of this gets merged, squash merge is used. Let me know if I should squash though.

@github-actions github-actions bot added the fuzzing Issues related to our fuzzing infrastructure label Apr 27, 2024
@github-actions GitHub Actions
Copy link

Subscribe to Label Action

cc @fitzgen

This issue or pull request has been labeled: "fuzzing", "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

  • fitzgen: fuzzing

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@FrankReh
Copy link
Contributor Author

FrankReh commented Apr 27, 2024 •
edited

I see the typos under 'deps' can't be fixed here. I'll revert those.

I've opened PRs on some WIT dependencies I've found along the way.

fitzgen
fitzgen approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fitzgen fitzgen added this pull request to the merge queue Apr 29, 2024
Merged via the queue into bytecodealliance:main with commit 1f39f63 Apr 29, 2024
21 checks passed
@FrankReh FrankReh deleted the comment-edits branch April 29, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

Assignees
No one assigned
Labels
fuzzing Issues related to our fuzzing infrastructure wasmtime:api Related to the API of the `wasmtime` crate itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FrankReh @fitzgen