Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record cargo-vet violations for older zstd versions #8278

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jameysharp
Copy link
Contributor

When I tried to audit our previous exemption for zstd, I found two buffer overruns which were reachable from safe Rust, although not reachable from Wasmtime. I got them fixed upstream but didn't update our cargo-vet audits to reflect the issue with the older versions.

Alex updated our dependencies to pull in the fixed versions in #7870, and this PR notes for the benefit of anyone importing the Bytecode Alliance audit set that older versions should not be used.

See gyscos/zstd-rs#231

When I tried to audit our previous exemption for zstd, I found two
buffer overruns which were reachable from safe Rust, although not
reachable from Wasmtime. I got them fixed upstream but didn't update our
cargo-vet audits to reflect the issue with the older versions.

Alex updated our dependencies to pull in the fixed versions in bytecodealliance#7870,
and this PR notes for the benefit of anyone importing the Bytecode
Alliance audit set that older versions should not be used.

See gyscos/zstd-rs#231
@jameysharp jameysharp requested a review from a team as a code owner April 1, 2024 21:05
@jameysharp jameysharp requested review from alexcrichton and removed request for a team April 1, 2024 21:05
@jameysharp
Copy link
Contributor Author

I'm confused by the CI failure here. I ran cargo vet locally and, although it complained about the new wasmtime-slab crate not having an audit-as-crates-io entry, it didn't complain about my actual changes. However I do get the same errors as in CI if I used cargo vet --locked; maybe the audit-as-crates-io thing masked the issue.

Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally get pretty confused with the interfactions of our configuration and new crates we add. I think it's an unfortunate interaction by how when a new crate is added it's not published on crates.io but then later on once it gets published we need new configuration, but only after it's later been published. Or... something like that? I've never bottomed it out to fully understand what's happening here, I tend to just throw things at the wall and see what sticks.

@alexcrichton
Copy link
Member

You may need to remove ~/.cache/cargo-vet, I just did that to resolve a difference I was seeing on CI as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants