Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serve guest-profiler results from a local web server #7832

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jameysharp
Copy link
Contributor

This is a proof of concept for #7666, but needs quite a bit of polish before merging.

This is a proof of concept for bytecodealliance#7666, but needs quite a bit of polish
before merging.
@jameysharp
Copy link
Contributor Author

If anyone has suggestions on how to do this better I'd be interested to hear them. In particular, I'm not happy with how many crate dependencies I had to add to the Wasmtime CLI to make this work.

Currently this PR reflects just enough hacking together of pieces to prove that #7666 is possible, so I'm not looking for review on small details, just the big picture design questions.

@tschneidereit
Copy link
Member

An alternative approach that shouldn't introduce any additional runtime dependencies would be to self-host this. I.e., to embed a wasi-http/proxy component that can load the profile from a pre-opened directory and serve it from the incoming-handler.

Such a component should be straightforward to run, and, after stripping, be quite small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants