Commits on Nov 4, 2022

1. Fix mprotect failures by enabling cranelift-jit selinux-fix …

   The sample program in cranelift/filetests/src/function_runner.rs
   would abort with an mprotect failure under certain circumstances,
   see bytecodealliance#4453 (comment)
   
   Root cause was that enabling PROT_EXEC on the main process heap
   may be prohibited, depending on Linux distro and version.
   
   This only shows up in the doc test sample program because the main
   clif-util is multi-threaded and therefore allocations will happen
   on glibc's per-thread heap, which is allocated via mmap, and not
   the main process heap.
   
   Work around the problem by enabling the "selinux-fix" feature of
   the cranelift-jit crate dependency in the filetests.  Note that
   this didn't compile out of the box, so a separate fix is also
   required and provided as part of this PR.
   
   Going forward, it would be preferable to always use mmap to allocate
   the backing memory for JITted code.

   

   uweigand committed Nov 4, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for fec18b5
   • Browse repository at this point

   Copy the full SHA

   fec18b5 View commit details

   Browse the repository at this point in the history