Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cranelift/x64: fix register allocator metadata for 8-bit divides. #4332

Merged
merged 1 commit into from Jun 27, 2022

Commits on Jun 27, 2022

  1. Cranelift/x64: fix register allocator metadata for 8-bit divides.

    `idiv` on x86-64 only reads `rdx`/`edx`/`dx`/`dl` for divides with width
    greater than 8 bits; for an 8-bit divide, it reads the whole 16-bit
    divisor from `ax`, as our CISC ancestors intended. This PR fixes the
    metadata to avoid a regalloc panic (due to undefined `rdx`) in this
    case. Does not affect Wasmtime or other Wasm-frontend embedders.
    cfallin committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    5050271 View commit details
    Browse the repository at this point in the history