New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wasmtime-wasi-http
shouldn't add the default port to outbound host
header
#8430
Comments
cc @elliottt |
lann
changed the title
Apr 22, 2024
wasmtime-wasi-http
shouldn't add the default port to outbound `host headerwasmtime-wasi-http
shouldn't add the default port to outbound host
header
elliottt
added a commit
to elliottt/wasmtime
that referenced
this issue
May 6, 2024
alexcrichton
pushed a commit
to alexcrichton/wasmtime
that referenced
this issue
May 7, 2024
alexcrichton
added a commit
that referenced
this issue
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The outbound HTTP implementation will add a default port to the URI authority if not present:
wasmtime/crates/wasi-http/src/http_impl.rs
Lines 68 to 69 in 1fa8de1
As reported on Zulip and as a Spin issue, this causes breakage with AWS signed requests, which include the exact host header value in the signature payload.
I believe the current behavior is incorrect. Per the HTTP/1.1 spec:
The text was updated successfully, but these errors were encountered: