Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winch: Aarch64 MacroAssembler completeness #8321

Open
11 of 51 tasks
saulecabrera opened this issue Apr 10, 2024 · 3 comments
Open
11 of 51 tasks

winch: Aarch64 MacroAssembler completeness #8321

saulecabrera opened this issue Apr 10, 2024 · 3 comments
Labels
winch Winch issues or pull requests

Comments

@saulecabrera
Copy link
Member

saulecabrera commented Apr 10, 2024

Winch's support for Aarch64 is minimal. The objective of this issue to track the missing items in order to bring the Aarch64 MacroAssembler to parity with the x64 implementation.

If you're interested in taking on any of the elements below, please add your name beside it to signal that you're actively working on it (if you don't have permission to edit this issue, feel free to reach out via Zulip).

  • Stack checks ( check_stack)
  • address_from_sp
  • address_at_sp
  • address_at_vmctx
  • wasm_store
  • wasm_load
  • call
  • load_ptr
  • load_addr
  • pop
  • cmov
  • checked_uadd
  • float_add (@evacchi)
  • float_sub(@evacchi)
  • float_mul(@evacchi)
  • float_div(@evacchi)
  • float_min(@evacchi)
  • float_max(@evacchi)
  • float_copysign (@evacchi)
  • float_neg (@evacchi)
  • float_abs (@evacchi)
  • float_round(@evacchi)
  • float_sqrt(@evacchi)
  • and
  • or
  • xor
  • shift
  • div
  • rem
  • zero
  • popcnt
  • unsigned_truncate
  • signed_convert
  • unsigned_convert
  • reinterpret_float_as_int
  • reinterpret_int_as_float
  • demote
  • promote
  • cmp
  • cmp_with_set
  • clz
  • ctz
  • wrap
  • extend
  • branch
  • jmp
  • unreachable
  • jmp_table
  • trap
  • trapz
  • trapif
@saulecabrera saulecabrera added the winch Winch issues or pull requests label Apr 10, 2024
Copy link

Subscribe to Label Action

cc @saulecabrera

This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

  • saulecabrera: winch

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@lpereira
Copy link
Contributor

Sorry for looking at this only now -- but I should have some of these instructions implemented soon. I've been caught up with other things but want to resume work on this ASAP.

@fitzgen
Copy link
Member

fitzgen commented Apr 18, 2024

@lpereira to prevent accidental duplication of work and to help minimize conflicts and the need for rebases, could you edit the OP issue to add your name next to the instructions you're currently working on implementing? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
winch Winch issues or pull requests
Projects
Status: No status
Development

No branches or pull requests

3 participants