Skip to content

Commit

Permalink
Upgrade to regalloc2 v0.2.3 to get bugfix from bytecodealliance/regal…
Browse files Browse the repository at this point in the history
…loc2#60. (#4333)

* Upgrade to regalloc2 v0.2.3 to get bugfix from bytecodealliance/regalloc2#60.

* Update RELEASES.md.

* Update two compile tests based on slightly shifting regalloc output.

* Add dividing line in RELEASES.md as per format.
  • Loading branch information
cfallin committed Jun 27, 2022
1 parent b3ad5f9 commit d421fad
Show file tree
Hide file tree
Showing 5 changed files with 28 additions and 13 deletions.
4 changes: 2 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 15 additions & 0 deletions RELEASES.md
@@ -1,5 +1,20 @@
--------------------------------------------------------------------------------

## 0.38.1

Released 2022-06-27.

### Fixed.

* A register allocator bug was fixed that could affect direct users of
Cranelift who use struct-return (`sret`) arguments. The bug had to do with
the handling of physical register constraints in the function prologue. No
impact should be possible for users of Cranelift via the Wasm frontend,
including Wasmtime.
[regalloc2#60](https://github.com/bytecodealliance/regalloc2/pull/60)

--------------------------------------------------------------------------------

## 0.38.0

Released 2022-06-21.
Expand Down
2 changes: 1 addition & 1 deletion cranelift/codegen/Cargo.toml
Expand Up @@ -23,7 +23,7 @@ serde = { version = "1.0.94", features = ["derive"], optional = true }
bincode = { version = "1.2.1", optional = true }
gimli = { version = "0.26.0", default-features = false, features = ["write"], optional = true }
smallvec = { version = "1.6.1" }
regalloc2 = { version = "0.2.2", features = ["checker"] }
regalloc2 = { version = "0.2.3", features = ["checker"] }
souper-ir = { version = "2.1.0", optional = true }
# It is a goal of the cranelift-codegen crate to have minimal external dependencies.
# Please don't add any unless they are essential to the task of creating binary
Expand Down
8 changes: 4 additions & 4 deletions cranelift/filetests/filetests/isa/aarch64/reftypes.clif
Expand Up @@ -72,20 +72,20 @@ block3(v7: r64, v8: r64):
; ldr x3, 8 ; b 12 ; data TestCase { length: 1, ascii: [102, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0] } + 0
; blr x3
; mov x9, sp
; ldr x10, [sp, #8]
; str x10, [x9]
; ldr x11, [sp, #8]
; str x11, [x9]
; and w7, w0, #1
; cbz x7, label1 ; b label3
; block1:
; b label2
; block2:
; mov x1, x10
; mov x1, x11
; ldr x0, [sp, #16]
; b label5
; block3:
; b label4
; block4:
; mov x0, x10
; mov x0, x11
; ldr x1, [sp, #16]
; b label5
; block5:
Expand Down
12 changes: 6 additions & 6 deletions cranelift/filetests/filetests/isa/s390x/reftypes.clif
Expand Up @@ -74,21 +74,21 @@ block3(v7: r64, v8: r64):
; bras %r1, 12 ; data %f + 0 ; lg %r5, 0(%r1)
; basr %r14, %r5
; la %r3, 160(%r15)
; lg %r4, 168(%r15)
; stg %r4, 0(%r3)
; llcr %r5, %r2
; chi %r5, 0
; lg %r5, 168(%r15)
; stg %r5, 0(%r3)
; llcr %r4, %r2
; chi %r4, 0
; jgnlh label1 ; jg label3
; block1:
; jg label2
; block2:
; lgr %r3, %r4
; lgr %r3, %r5
; lg %r2, 176(%r15)
; jg label5
; block3:
; jg label4
; block4:
; lgr %r2, %r4
; lgr %r2, %r5
; lg %r3, 176(%r15)
; jg label5
; block5:
Expand Down

0 comments on commit d421fad

Please sign in to comment.