Add NOEXEC_SEAL and EXEC to MemfdFlags #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusty-snake
force-pushed
the
memfd_create-exec
branch
2 times, most recently
from
2f69e0e
to
4fc6420
Compare
|
Bump(?) |
|
It looks like |
|
Exactly. I'm not sure how to proceeded. Supporting only linux_raw sound wrong. Do we want to wait on libc or define them ourself? |
|
The libc crate doesn't pick up new features automatically; I'll need someone to submit a PR. Rustix does occasionally define values for itself, but we usually prefer to submit PRs to libc to upstream values. So submitting |
|
libc merge request merged just now. |
rusty-snake
force-pushed
the
memfd_create-exec
branch
from
4fc6420
to
79ecabf
Compare
NOEXEC_SEAL and EXEC constants were added in libc 0.2.153
Enabling non-executable memfds: https://lwn.net/Articles/918106/
rusty-snake
force-pushed
the
memfd_create-exec
branch
from
79ecabf
to
46ab1f5
Compare
|
CI failures seem to be unrelated. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling non-executable memfds: https://lwn.net/Articles/918106/