Use platform independent IpAddr and SocketAddr
#433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niluxv
force-pushed
the
platform-independent-addr
branch
from
c9a0265
to
a7366d2
Compare
|
It could very well be that I broke 1.48 compatibility (I wasn't able to test locally; wanted to check it by letting CI run), but the errors in the CI I see right now don't seem related to any changes in this PR. |
niluxv
force-pushed
the
platform-independent-addr
branch
from
a7366d2
to
69d8567
Compare
|
CI failures are caused by this change in |
|
The libc issue has been reverted, so CI should work again. Any way to retrigger CI without making changes to the PR? |
Update `src/net/ip.rs` and `src/net/addr.rs` to use the new std code, making these structures platform independent. Doesn't include the new Debug/Display formatting code for these structures, although that could have been added now that it doesn't depend on std anymore.
niluxv
force-pushed
the
platform-independent-addr
branch
from
69d8567
to
7abd7bd
Compare
|
Rebased, and the CI seems to pass now. (I don't know why macos test was cancelled.) |
|
It looks like it was a transient CI failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
src/net/ip.rsandsrc/net/addr.rsto use the new std code, making these structures platform independent.Doesn't include the new Debug/Display formatting code for these structures, although that could be added now that it doesn't depend on std anymore.