Replace Ioctl::OPCODE with an Ioctl::opcode() method
#1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breaking API change. This is needed for something like `SPI_IOC_MESSAGE(N)`, which takes an array of `N` `spi_ioc_transfer` structs. Which nix this ioctl would use `ioctl_write_buf!`. I'm not sure what other ioctls use this. It probably should also have a helper type implementing `Ioctl` for this use case. Though it would help to know that it works for more than one ioctl...
sunfishcode
added
the
semver bump
|
This change looks reasonable to me. That said, I don't currently have a schedule for when the next semver break will happen. |
|
Right. It's not urgent, but seems good to make sure some change like this gets in whenever there is another API break. I think with this, all ioctls should be possible to support. Though it's hard to be sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking API change.
This is needed for something like
SPI_IOC_MESSAGE(N), which takes an array ofNspi_ioc_transferstructs. Which nix this ioctl would useioctl_write_buf!. I'm not sure what other ioctls use this.It probably should also have a helper type implementing
Ioctlfor this use case. Though it would help to know that it works for more than one ioctl...