Add mount_setattr
#1002
Draft
Add mount_setattr
#1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yujincheng08
force-pushed
the
mount_setattr
branch
3 times, most recently
from
396991e
to
78c5696
Compare
yujincheng08
force-pushed
the
mount_setattr
branch
from
78c5696
to
2f77562
Compare
sunfishcode
reviewed
Feb 6, 2024
| #[derive(Debug, Copy, Clone)] | ||
| #[allow(missing_docs)] | ||
| pub struct MountAttr<'a> { | ||
| pub attr_set: MountAttrFlags, |
There was a problem hiding this comment.
According to Linux's documentation, attr_set is a __u64, while MountAttrFlags is currently a c_uint. Could you add a test testing that the layout matches, following one of the "layouts" tests in the tree?
| use crate::fs::AtFlags; | ||
| use crate::{backend, io, path}; | ||
|
|
||
| /// `mount_setattr(dir_fd, path, flags, mount_attr)` |
There was a problem hiding this comment.
Since there is no mount_setattr declaration exposed in C, could you change this comment to syscall(SYS_mount_setattr, ...)?
If you don't have a need for it at this time, then we don't need to. If someone later has a need for it, we can add another function that exposes it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preliminary implementation of
mount_setattr.A few notes:
sizenon-exported. Should we export this?mount_setattrinmisc.rsbecause I am going to add statmount and listmount syscall once 6.8 releases andlibcadds the syscall number.Fix #975