Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ordering of events returned on poll() #862

Merged
merged 4 commits into from
May 10, 2024
Merged

fix: ordering of events returned on poll() #862

merged 4 commits into from
May 10, 2024

Conversation

de-sh
Copy link
Member

@de-sh de-sh commented May 9, 2024

Fixes #860

Type of change

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Formatted with cargo fmt
  • Make an entry to CHANGELOG.md if it's relevant to the users of the library. If it's not relevant mention why.

@coveralls
Copy link

coveralls commented May 10, 2024

Pull Request Test Coverage Report for Build 9035758375

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 8 (50.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 36.526%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rumqttc/src/v5/state.rs 2 3 66.67%
rumqttd/src/router/routing.rs 0 1 0.0%
rumqttd/src/router/alertlog.rs 0 2 0.0%
Totals Coverage Status
Change from base Build 8762117251: 0.1%
Covered Lines: 5983
Relevant Lines: 16380

💛 - Coveralls

@de-sh de-sh marked this pull request as ready for review May 10, 2024 17:16
@de-sh de-sh merged commit 7f594f8 into main May 10, 2024
3 checks passed
@de-sh de-sh deleted the fix-order branch May 10, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rumqttc - Event ordering of puback is incorrect
2 participants