Interactions: the Buttons #933

FedorLap2006 · 2021-05-16T22:05:46Z

Hello everyone. Just finished implementing buttons functionality for DiscordGo. Looking forward a feedback.

interactions.go

components.go

examples/components/main.go

interactions.go

FedorLap2006 · 2021-05-18T15:25:47Z

After some discussion about InteractionData. I'd say that we decided to separate data into different structures. And I personally decided to make it an interface. So, waiting for feedback!

…mple

interactions.go

FedorLap2006 · 2021-05-26T22:15:40Z

Hello everyone. It seems that documentation has been published and the buttons are ungated. I think It's time to mark this PR as ready for review. Well, enjoy the buttons!

interactions.go

yyewolf · 2021-05-28T19:08:51Z

You can add the "Component" feature to these endpoints :

https://discord.com/developers/docs/resources/webhook#edit-webhook-message
https://discord.com/developers/docs/resources/webhook#execute-webhook
https://discord.com/developers/docs/interactions/slash-commands#edit-original-interaction-response

They all support perfectly fine components objects and are needed to put buttons on a follow up message for example.

components.go

mcdearman · 2021-06-22T05:47:17Z

My command router which just operates off of a MessageCreate handler breaks with this PR with the following trace:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x71daff]

goroutine 56 [running]:
github.com/bwmarrin/discordgo.(*Message).UnmarshalJSON(0x0, 0xc000438600, 0x2c3, 0x300, 0x0, 0x0)
        /home/chris/go/pkg/mod/github.com/!fedor!lap2006/discordgo@v0.22.1-0.20210619182440-23a197a98005/message.go:144 +0x9f
encoding/json.(*decodeState).object(0xc000284420, 0xa0d840, 0xc000010218, 0x16, 0xc000284448, 0xc0000f9d7b)
        /home/chris/go/src/encoding/json/decode.go:609 +0x20a3
encoding/json.(*decodeState).value(0xc000284420, 0xa0d840, 0xc000010218, 0x16, 0xc0000f9d68, 0x524285)
        /home/chris/go/src/encoding/json/decode.go:370 +0x6d
encoding/json.(*decodeState).unmarshal(0xc000284420, 0xa0d840, 0xc000010218, 0xc000284448, 0x0)
        /home/chris/go/src/encoding/json/decode.go:180 +0x1f4
encoding/json.Unmarshal(0xc000438600, 0x2c3, 0x300, 0xa0d840, 0xc000010218, 0x1, 0x0)
        /home/chris/go/src/encoding/json/decode.go:107 +0x11a
github.com/bwmarrin/discordgo.(*Session).onEvent(0xc00024ae00, 0x1, 0xc00001a400, 0x2eb, 0x400, 0x0, 0x0, 0x0)
        /home/chris/go/pkg/mod/github.com/!fedor!lap2006/discordgo@v0.22.1-0.20210619182440-23a197a98005/wsapi.go:584 +0xf65
github.com/bwmarrin/discordgo.(*Session).listen(0xc00024ae00, 0xc0003609a0, 0xc0004f2480)
        /home/chris/go/pkg/mod/github.com/!fedor!lap2006/discordgo@v0.22.1-0.20210619182440-23a197a98005/wsapi.go:250 +0x7e
created by github.com/bwmarrin/discordgo.(*Session).Open
        /home/chris/go/pkg/mod/github.com/!fedor!lap2006/discordgo@v0.22.1-0.20210619182440-23a197a98005/wsapi.go:202 +0xbc5
exit status 2

FedorLap2006 · 2021-06-22T21:29:26Z

My command router which just operates off of a MessageCreate handler breaks with this PR with the following trace:

@ChrisMcDearman Should be fixed now.

components.go

CarsonHoffman · 2021-06-23T00:31:29Z

Outside of a few outstanding small things, this is looking quite solid to me; the API surface is definitely cleaner than at the start. Not to jinx it, but as long as nothing else comes up in the near future, I'm excited to get this merged in! 🤠

FedorLap2006 · 2021-06-23T16:07:58Z

I agree with @CarsonHoffman - this is pretty much it. But if anyone wanna give additional review/feedback, feel free to, at least until Carson will merge it 🤠

FedorLap2006 · 2021-06-23T21:33:44Z

Oh, yeah, forgot about them!

FedorLap2006 · 2021-06-27T16:18:50Z

Thanks everyone for contribution and feedbacks. And special thanks @CarsonHoffman for his patience and reviews! 🚀

0xTenzo · 2021-07-11T15:26:12Z

Thanks for this!

Could we get some comments in https://github.com/bwmarrin/discordgo/blob/master/examples/components/main.go about how to use this / what it does?

It's not immediately clear what this new interactions functionality is, or what we are supposed to see when running the example. After attempting it, I was met with:

Cannot create slash command: HTTP 403 Forbidden, {"message": "Missing Access", "code": 50001}.

Are there some prerequisite permissions that the bot needs? If so, a comment on adding them would be great.

* Interactions: buttons * Doc fix * Gofmt fix * Fix typo * Remaking interaction data into interface * Godoc fix * Gofmt fix * Godoc fix * InteractionData helper functions and some fixes in slash commands example * Fix components example * Yet another fix of components example * Fix interaction unmarshaling * Gofmt fix * Godoc fix * Gofmt fix * Corrected naming and docs * Rolled back API version * Requested fixes * Added support of components to webhook and regular messages * Fix components unmarshaling * Godoc fix * Requested fixes * Fixed unmarshaling issues * Components example: cleanup * Added components tracking to state * Requested fixes * Renaming fix * Remove more named returns * Minor English fixes Co-authored-by: Carson Hoffman <c@rsonhoffman.com>

* Interactions: the Buttons (#933) * Interactions: buttons * Doc fix * Gofmt fix * Fix typo * Remaking interaction data into interface * Godoc fix * Gofmt fix * Godoc fix * InteractionData helper functions and some fixes in slash commands example * Fix components example * Yet another fix of components example * Fix interaction unmarshaling * Gofmt fix * Godoc fix * Gofmt fix * Corrected naming and docs * Rolled back API version * Requested fixes * Added support of components to webhook and regular messages * Fix components unmarshaling * Godoc fix * Requested fixes * Fixed unmarshaling issues * Components example: cleanup * Added components tracking to state * Requested fixes * Renaming fix * Remove more named returns * Minor English fixes Co-authored-by: Carson Hoffman <c@rsonhoffman.com> * Doc fix * Gofmt fix * Fix typo * Remaking interaction data into interface * Godoc fix * Gofmt fix * Godoc fix * InteractionData helper functions and some fixes in slash commands example * Fix components example * Yet another fix of components example * Fix interaction unmarshaling * Godoc fix * Gofmt fix * Corrected naming and docs * Rolled back API version * Requested fixes * Added support of components to webhook and regular messages * Interactions: select menus * Example fix * Merge fix * Some fixes * Added missing documentation * Fix components unmarshaling * Godoc fix * Requested fixes * Fixed unmarshaling issues * Components example: cleanup * Gofmt fix * Godoc fix * URL field renaming fix * Added flags to followups * Updated components example * Fixed typo in components example * Merge fix * Improve handling of invalid interaction situations * support allowing webhook edits with files, and responding to interactions with files (#931) * allow files in webhook message edits * add Files to WebhookEdit struct * move the construction of the multipart body for files into a shared function * allow interaction responses to have files * go fmt * fix err shadowing * document MakeFilesBody * rename MakeFilesBody -> EncodeWithFiles. fix InteractionRespond responding twice * use resp in InteractionRespond files, add basic-command-with-files example command * import strings and go fmt * EncodeWithFiles -> MultiPartBodyWithJSON * go fmt * fix example for slash_commands * move files to responsedata * Merge fixes * Fixed rebase consequences Co-authored-by: Carson Hoffman <c@rsonhoffman.com> Co-authored-by: plally <pierce@vulpes.dev>

* Interactions: buttons * Doc fix * Gofmt fix * Fix typo * Remaking interaction data into interface * Godoc fix * Gofmt fix * Godoc fix * InteractionData helper functions and some fixes in slash commands example * Fix components example * Yet another fix of components example * Fix interaction unmarshaling * Gofmt fix * Godoc fix * Gofmt fix * Corrected naming and docs * Rolled back API version * Requested fixes * Added support of components to webhook and regular messages * Fix components unmarshaling * Godoc fix * Requested fixes * Fixed unmarshaling issues * Components example: cleanup * Added components tracking to state * Requested fixes * Renaming fix * Remove more named returns * Minor English fixes Co-authored-by: Carson Hoffman <c@rsonhoffman.com>

* Interactions: the Buttons (bwmarrin#933) * Interactions: buttons * Doc fix * Gofmt fix * Fix typo * Remaking interaction data into interface * Godoc fix * Gofmt fix * Godoc fix * InteractionData helper functions and some fixes in slash commands example * Fix components example * Yet another fix of components example * Fix interaction unmarshaling * Gofmt fix * Godoc fix * Gofmt fix * Corrected naming and docs * Rolled back API version * Requested fixes * Added support of components to webhook and regular messages * Fix components unmarshaling * Godoc fix * Requested fixes * Fixed unmarshaling issues * Components example: cleanup * Added components tracking to state * Requested fixes * Renaming fix * Remove more named returns * Minor English fixes Co-authored-by: Carson Hoffman <c@rsonhoffman.com> * Doc fix * Gofmt fix * Fix typo * Remaking interaction data into interface * Godoc fix * Gofmt fix * Godoc fix * InteractionData helper functions and some fixes in slash commands example * Fix components example * Yet another fix of components example * Fix interaction unmarshaling * Godoc fix * Gofmt fix * Corrected naming and docs * Rolled back API version * Requested fixes * Added support of components to webhook and regular messages * Interactions: select menus * Example fix * Merge fix * Some fixes * Added missing documentation * Fix components unmarshaling * Godoc fix * Requested fixes * Fixed unmarshaling issues * Components example: cleanup * Gofmt fix * Godoc fix * URL field renaming fix * Added flags to followups * Updated components example * Fixed typo in components example * Merge fix * Improve handling of invalid interaction situations * support allowing webhook edits with files, and responding to interactions with files (bwmarrin#931) * allow files in webhook message edits * add Files to WebhookEdit struct * move the construction of the multipart body for files into a shared function * allow interaction responses to have files * go fmt * fix err shadowing * document MakeFilesBody * rename MakeFilesBody -> EncodeWithFiles. fix InteractionRespond responding twice * use resp in InteractionRespond files, add basic-command-with-files example command * import strings and go fmt * EncodeWithFiles -> MultiPartBodyWithJSON * go fmt * fix example for slash_commands * move files to responsedata * Merge fixes * Fixed rebase consequences Co-authored-by: Carson Hoffman <c@rsonhoffman.com> Co-authored-by: plally <pierce@vulpes.dev>

FedorLap2006 added 2 commits May 17, 2021 00:55

Interactions: buttons

e6cc744

Fix merge

4a8d880

FedorLap2006 commented May 16, 2021

View reviewed changes

interactions.go Outdated Show resolved Hide resolved

FedorLap2006 commented May 16, 2021

View reviewed changes

components.go Outdated Show resolved Hide resolved

FedorLap2006 added 2 commits May 17, 2021 01:18

Doc fix

8930b92

Gofmt fix

23fb77c

phenpessoa reviewed May 17, 2021

View reviewed changes

examples/components/main.go Outdated Show resolved Hide resolved

Fix typo

93b0bcc

FedorLap2006 changed the title ~~The Interactions: Buttons~~ Interactions: the Buttons May 17, 2021

Strum355 reviewed May 17, 2021

View reviewed changes

interactions.go Outdated Show resolved Hide resolved

Remaking interaction data into interface

26e0fe2

FedorLap2006 and others added 11 commits May 18, 2021 18:30

Godoc fix

5656869

Gofmt fix

4ed73c2

Godoc fix

e10d270

InteractionData helper functions and some fixes in slash commands exa…

9646e09

…mple

Fix components example

e946bc8

Yet another fix of components example

5dfd40e

Merge branch 'bwmarrin:master' into master

a081bca

Fix interaction unmarshaling

3c6bda6

Gofmt fix

72aac18

Godoc fix

8c792ad

Gofmt fix

f5c78d0

typpo reviewed May 25, 2021

View reviewed changes

interactions.go Outdated Show resolved Hide resolved

Corrected naming and docs

e7fb87f

FedorLap2006 marked this pull request as ready for review May 26, 2021 22:15

FedorLap2006 requested a review from CarsonHoffman May 26, 2021 22:51

zacharyburkett reviewed May 28, 2021

View reviewed changes

interactions.go Outdated Show resolved Hide resolved

CarsonHoffman reviewed Jun 19, 2021

View reviewed changes

components.go Outdated Show resolved Hide resolved

Requested fixes

23a197a

CarsonHoffman reviewed Jun 20, 2021

View reviewed changes

components.go Show resolved Hide resolved

FedorLap2006 added 3 commits June 23, 2021 00:24

Fixed unmarshaling issues

7b457eb

Components example: cleanup

9dbe959

Added components tracking to state

6f3aa6b

FedorLap2006 requested a review from CarsonHoffman June 22, 2021 21:28

phenpessoa mentioned this pull request Jun 22, 2021

Components Support #956

Closed

CarsonHoffman reviewed Jun 23, 2021

View reviewed changes

components.go Outdated Show resolved Hide resolved

CarsonHoffman requested changes Jun 23, 2021

View reviewed changes

components.go Outdated Show resolved Hide resolved

FedorLap2006 added 2 commits June 23, 2021 18:47

Requested fixes

881a24b

Renaming fix

bcc0a2f

FedorLap2006 requested a review from CarsonHoffman June 23, 2021 16:10

Remove more named returns

5149e24

FedorLap2006 and others added 2 commits June 27, 2021 01:58

Merge branch 'bwmarrin:master' into master

10b295f

Minor English fixes

3bc7e7b

CarsonHoffman merged commit 421e149 into bwmarrin:master Jun 27, 2021

FedorLap2006 added this to the v0.24.0 milestone Feb 27, 2022

FedorLap2006 added the feature Feature implementation label Feb 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Interactions: the Buttons #933

Interactions: the Buttons #933

FedorLap2006 commented May 16, 2021

FedorLap2006 commented May 18, 2021

FedorLap2006 commented May 26, 2021

yyewolf commented May 28, 2021

mcdearman commented Jun 22, 2021 •

edited

FedorLap2006 commented Jun 22, 2021

CarsonHoffman commented Jun 23, 2021

FedorLap2006 commented Jun 23, 2021 •

edited

FedorLap2006 commented Jun 23, 2021

FedorLap2006 commented Jun 27, 2021 •

edited

0xTenzo commented Jul 11, 2021

Interactions: the Buttons #933

Interactions: the Buttons #933

Conversation

FedorLap2006 commented May 16, 2021

FedorLap2006 commented May 18, 2021

FedorLap2006 commented May 26, 2021

yyewolf commented May 28, 2021

mcdearman commented Jun 22, 2021 • edited

FedorLap2006 commented Jun 22, 2021

CarsonHoffman commented Jun 23, 2021

FedorLap2006 commented Jun 23, 2021 • edited

FedorLap2006 commented Jun 23, 2021

FedorLap2006 commented Jun 27, 2021 • edited

0xTenzo commented Jul 11, 2021

mcdearman commented Jun 22, 2021 •

edited

FedorLap2006 commented Jun 23, 2021 •

edited

FedorLap2006 commented Jun 27, 2021 •

edited