feat(wsapi): Gracefully close the websocket connection #1347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a
time.Sleep(1 * time.Second)
fromSession.Close()
.Instead, I implemented the websocket close handshake described in this comment: gorilla/websocket#448 (comment)
The reason I would like to see this change is that the
time.Sleep
was causing my unit tests to run slowly.I tested this change by running this program a few times: