Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make WebhookEdit fields pointers #1174

Merged
merged 2 commits into from May 14, 2022
Merged

make WebhookEdit fields pointers #1174

merged 2 commits into from May 14, 2022

Conversation

plally
Copy link
Contributor

@plally plally commented May 1, 2022

These need to be pointers to allow removing embeds, content, and components from an existing message.

omitempty was added to components to allow keeping the existing components on a message when calling WebhookEdit

@plally
Copy link
Contributor Author

plally commented May 1, 2022

This addresses #914

@FedorLap2006 FedorLap2006 added feature Feature implementation breaking changes Contains breaking changes. Should be reflected in the changelog labels May 1, 2022
@FedorLap2006
Copy link
Collaborator

Thanks for your contribution!

@FedorLap2006 FedorLap2006 merged commit c29e0d7 into bwmarrin:master May 14, 2022
@plally plally deleted the webhook-edit-struct-pointers branch May 14, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedorLap2006 FedorLap2006 FedorLap2006 approved these changes

Assignees
No one assigned
Labels
breaking changes Contains breaking changes. Should be reflected in the changelog feature Feature implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@plally @FedorLap2006