Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated RequestGuildMembers method and GuildMembersChunk event struct #1156

Merged
merged 5 commits into from Apr 15, 2022
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 7 additions & 5 deletions events.go
Expand Up @@ -187,11 +187,13 @@ type GuildEmojisUpdate struct {

// A GuildMembersChunk is the data for a GuildMembersChunk event.
type GuildMembersChunk struct {
GuildID string `json:"guild_id"`
Members []*Member `json:"members"`
ChunkIndex int `json:"chunk_index"`
ChunkCount int `json:"chunk_count"`
Presences []*Presence `json:"presences,omitempty"`
GuildID string `json:"guild_id"`
Members []*Member `json:"members"`
ChunkIndex int `json:"chunk_index"`
ChunkCount int `json:"chunk_count"`
NotFound []json.Number `json:"not_found,omitempty"`
Pancake-e marked this conversation as resolved.
Show resolved Hide resolved
Presences []*Presence `json:"presences,omitempty"`
Nonce string `json:"nonce,omitempty"`
}

// GuildIntegrationsUpdate is the data for a GuildIntegrationsUpdate event.
Expand Down
61 changes: 50 additions & 11 deletions wsapi.go
Expand Up @@ -409,10 +409,12 @@ func (s *Session) UpdateStatusComplex(usd UpdateStatusData) (err error) {
}

type requestGuildMembersData struct {
GuildIDs []string `json:"guild_id"`
Query string `json:"query"`
Limit int `json:"limit"`
Presences bool `json:"presences"`
GuildIDs []string `json:"guild_id"`
Query *string `json:"query,omitempty"`
UserIDs []json.Number `json:"user_ids,omitempty"`
Limit int `json:"limit"`
Nonce string `json:"nonce,omitempty"`
Presences bool `json:"presences"`
}

type requestGuildMembersOp struct {
Expand All @@ -425,29 +427,66 @@ type requestGuildMembersOp struct {
// guildID : Single Guild ID to request members of
// query : String that username starts with, leave empty to return all members
// limit : Max number of items to return, or 0 to request all members matched
// nonce : Nonce to identify the Guild Members Chunk response
// presences : Whether to request presences of guild members
func (s *Session) RequestGuildMembers(guildID string, query string, limit int, presences bool) (err error) {
func (s *Session) RequestGuildMembers(guildID, query string, limit int, nonce string, presences bool) error {
return s.RequestGuildMembersBatch([]string{guildID}, query, limit, nonce, presences)
}

// RequestGuildMembersList requests guild members from the gateway
// The gateway responds with GuildMembersChunk events
// guildID : Single Guild ID to request members of
// userIDs : Used to specify which users you wish to fetch
Pancake-e marked this conversation as resolved.
Show resolved Hide resolved
// limit : Max number of items to return, or 0 to request all members matched
// nonce : Nonce to identify the Guild Members Chunk response
// presences : Whether to request presences of guild members
func (s *Session) RequestGuildMembersList(guildID string, userIDs []string, limit int, nonce string, presences bool) error {
return s.RequestGuildMembersBatchList([]string{guildID}, userIDs, limit, nonce, presences)
}

// RequestGuildMembersBatch requests guild members from the gateway
// The gateway responds with GuildMembersChunk events
// guildID : Slice of guild IDs to request members of
// query : String that username starts with, leave empty to return all members
// limit : Max number of items to return, or 0 to request all members matched
// nonce : Nonce to identify the Guild Members Chunk response
// presences : Whether to request presences of guild members
func (s *Session) RequestGuildMembersBatch(guildIDs []string, query string, limit int, nonce string, presences bool) (err error) {
Pancake-e marked this conversation as resolved.
Show resolved Hide resolved
data := requestGuildMembersData{
GuildIDs: []string{guildID},
Query: query,
GuildIDs: guildIDs,
Query: &query,
Limit: limit,
Nonce: nonce,
Presences: presences,
}
err = s.requestGuildMembers(data)
return
}

// RequestGuildMembersBatch requests guild members from the gateway
// RequestGuildMembersBatchList requests guild members from the gateway
// The gateway responds with GuildMembersChunk events
// guildID : Slice of guild IDs to request members of
// query : String that username starts with, leave empty to return all members
// userIDs : Used to specify which users you wish to fetch
Pancake-e marked this conversation as resolved.
Show resolved Hide resolved
// limit : Max number of items to return, or 0 to request all members matched
// nonce : Nonce to identify the Guild Members Chunk response
// presences : Whether to request presences of guild members
func (s *Session) RequestGuildMembersBatch(guildIDs []string, query string, limit int, presences bool) (err error) {
func (s *Session) RequestGuildMembersBatchList(guildIDs []string, userIDs []string, limit int, nonce string, presences bool) (err error) {
Pancake-e marked this conversation as resolved.
Show resolved Hide resolved
if len(userIDs) == 0 {
return
Pancake-e marked this conversation as resolved.
Show resolved Hide resolved
}

// []json.Number is used here to prevent retry loop in
// 'ready' callback caused by non-digit characters
Pancake-e marked this conversation as resolved.
Show resolved Hide resolved
newUserIDs := make([]json.Number, len(userIDs))
for i, userID := range userIDs {
newUserIDs[i] = json.Number(userID)
}

data := requestGuildMembersData{
GuildIDs: guildIDs,
Query: query,
UserIDs: newUserIDs,
Limit: limit,
Nonce: nonce,
Presences: presences,
}
err = s.requestGuildMembers(data)
Expand Down