add missing json error codes #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FedorLap2006
requested changes
Feb 15, 2022
structs.go
Outdated
| ErrCodeInvalidOAuthState = 50012 | ||
| ErrCodeMissingPermissions = 50013 | ||
| ErrCodeInvalidAuthenticationToken = 50014 | ||
| ErrCodeNoteTooLong = 50015 |
There was a problem hiding this comment.
I think it was added by mistake to the docs, bots shouldn't be able to access notes at all.
structs.go
Outdated
| ErrCodeCannotSelfRedeemThisGift = 50054 | ||
| ErrCodeInvalidGuild = 50055 | ||
| ErrCodeInvalidMessageType = 50068 | ||
| ErrCodePaymentSourceRequiredToRedeemGift = 50070 |
There was a problem hiding this comment.
Note my comment for ErrCodeNoteTooLong
structs.go
Outdated
| ErrCodeCannotDeleteAChannelRequiredForCommunityGuilds = 50074 | ||
| ErrCodeInvalidStickerSent = 50081 | ||
| ErrCodePerformedOperationOnArchivedThread = 50083 | ||
| ErrCodeInvalidThreadNotificationSettings = 50084 |
There was a problem hiding this comment.
Note my comment for ErrCodeNoteTooLong
structs.go
Outdated
| ErrCodeThisServerNeedsMoreBoostsToPerformThisAction = 50101 | ||
| ErrCodeTheRequestBodyContainsInvalidJSON = 50109 | ||
|
|
||
| ErrCodeTwoFactorRequiredForThisOperation = 60003 |
There was a problem hiding this comment.
Note my comment for ErrCodeNoteTooLong
Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>
Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>
Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>
Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>
|
Thank you for your contribution! |
SmoothieNoIce
pushed a commit
to SmoothieNoIce/discordgo
that referenced
this pull request
Feb 17, 2022
* add missing json error codes * Update structs.go Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com> * Update structs.go Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com> * requested changes * Update structs.go Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com> * Update structs.go Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com> * formatting * add ErrCodeEmbedDisabled back Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing error codes from: https://discord.com/developers/docs/topics/opcodes-and-status-codes#json