fix: Handle InteractionResponseDeferredChannelMessageWithSource in slash commands example. Also refactoring. #1045

telephrag · 2021-12-03T11:44:09Z

In /responses command InteractionResponseDeferredChannelMessageWithSource was listed in options but was not handled inside handler function. In result when typing command /responses and selecting option "Deffered response..." bot would either crash or go into infinite loop not knowing how to handle request from user.

Moved handler functions and commands definitions to separate files.

FedorLap2006

Hi, everything looks good to me. But want to mention that we don't usually make go modules inside examples. Also I'm not sure if the slash commands example needs a readme, since it could be built with simple go build.

FedorLap2006 · 2021-12-08T23:53:54Z

examples/slash_commands/handlers.go

+	"github.com/bwmarrin/discordgo"
+)
+
+func SelectHandler(s *discordgo.Session, i *discordgo.InteractionCreate) {


This is not a critical problem, but I think this should be renamed to something else, it is quite confusing, since we have select components.

Ok, I will look into this on weekend.

It's done. Take a look.

FedorLap2006

Whoops, missed one thing

FedorLap2006 · 2021-12-28T22:15:08Z

examples/slash_commands/main.go

+const GuildID string = "Bot token goes here"
+const BotToken string = "Guild where the bot will be used"


I'm not sure if this is a good idea, since most of the time sensitive stuff is put into flags, plus it is easy to replace these values without recompiling the application again.

FedorLap2006 · 2022-03-23T18:31:43Z

Hi. Just wanted to check, if everything is okay and if you still want to continue development of this PR.
Because it would go pretty well with recent #1120 and #1129

telephrag · 2022-03-24T11:45:41Z

Sorry, no updates. Busy doing other things.

telephrag · 2022-04-02T14:41:35Z

Hi, I've started looking into this again. What should I do in presence of #1120 and #1129?

FedorLap2006 · 2022-04-02T14:51:24Z

Hi, I've started looking into this again. What should I do in presence of #1120 and #1129?

Good to know! Just wait until they'll be merged. However, while you wait, you can integrate the changes from the base branch.

telephrag · 2022-04-11T10:46:52Z

Closed it accidentally. I'm working on it right now and will reopen PR once I have something to commit.

… occurs inside one of the handlers.

telephrag · 2022-04-11T14:38:31Z

Changes from #1129 are integrated. If you decide to get #1120 done first it's fine, I can wait.

FedorLap2006 · 2022-04-14T13:20:06Z

examples/slash_commands/handlers.go

+func Login(ds *discordgo.Session, r *discordgo.Ready) {
+	log.Printf("Logged in as: %v#%v", ds.State.User.Username, ds.State.User.Discriminator)
+}


I think having anonymous handler would be better in this case, since it's just oneliner.

FedorLap2006 · 2022-04-14T13:21:11Z

examples/slash_commands/handlers.go

+	r := recover()
+	if r != nil {


Suggested change

r := recover()

if r != nil {

if err := recover(); err != nil {

FedorLap2006 · 2022-04-14T13:21:27Z

examples/slash_commands/handlers.go

+	r := recover()
+	if r != nil {
+		deleteCommands(ds, guildID)
+		log.Fatal("Error occured inside command handler")


Suggested change

log.Fatal("Error occured inside command handler")

log.Fatalf("Error occured inside command handler: %s", err)

FedorLap2006 · 2022-04-14T13:21:46Z

examples/slash_commands/handlers.go

+}
+
+func Basic(s *discordgo.Session, i *discordgo.InteractionCreate) {
+	panic("test")


Suggested change

panic("test")

FedorLap2006 · 2022-04-14T13:24:40Z

examples/slash_commands/main.go

-					"Also, as bonus... look at the original interaction response :D",
-			})
-		},
+	ds, err := discordgo.New("Bot " + *BotToken)


Not sure why you named the session ds, the convention is usually s

FedorLap2006 · 2022-04-14T13:39:13Z

examples/slash_commands/main.go

+func createCommands(ds *discordgo.Session, guildId string) {
+	var err error
+	for i, cmd := range commands {
+		commands[i], err = ds.ApplicationCommandCreate(


Since we're doing a refactoring of the example, I think it would be worthwhile to also replace ApplicationCommandCreate with ApplicationCommandBulkOverwrite here. While using Create & Delete is a lot cleaner (you don't affect other commands) and straightforward, they get ratelimited pretty quickly when using them on multiple commands.

FedorLap2006 · 2022-04-14T13:43:22Z

examples/slash_commands/main.go

 var (
 	GuildID        = flag.String("guild", "", "Test guild ID. If not passed - bot registers commands globally")
 	BotToken       = flag.String("token", "", "Bot access token")
-	RemoveCommands = flag.Bool("rmcmd", true, "Remove all commands after shutdowning or not")
+	RemoveCommands = flag.Bool("rmcmd", true, "Weather to remove all commands after shutdowning or not")


Also speaking of performance and ratelimit issues, I think it would be better to set the default value to false here. That way each time you run the application you won't need to wait until it deletes the commands.

Otherwise, in addition to usage of ApplicationCommandBulkOverwrite, we can replace this parameter with -clean, which when enabled would use ApplicationCommandCreate & ApplicationCommandDelete instead of ApplicationCommandBulkOverwrite. That way it also might make sense to separate functionality into createCommands function instead of doing it directly in main.

FedorLap2006 · 2022-04-14T13:45:32Z

examples/slash_commands/handlers.go

+}
+
+func BasicWithFile(s *discordgo.Session, i *discordgo.InteractionCreate) {
+


Suggested change

FedorLap2006 · 2022-04-14T13:45:42Z

examples/slash_commands/handlers.go

+}
+
+func Subcommands(s *discordgo.Session, i *discordgo.InteractionCreate) {
+


Suggested change

FedorLap2006 · 2022-04-14T13:45:49Z

examples/slash_commands/handlers.go

+}
+
+func Responses(s *discordgo.Session, i *discordgo.InteractionCreate) {
+


Suggested change

FedorLap2006 · 2022-04-14T13:50:47Z

Changes from #1129 are integrated. If you decide to get #1120 done first it's fine, I can wait.

I think yeah, better wait until that one is merged

…ed panic handling.

telephrag changed the title ~~Refactoring and bug fix in slash commands and example.~~ Refactoring and bug fix in slash commands example. Dec 3, 2021

telephrag changed the title ~~Refactoring and bug fix in slash commands example.~~ fix: Handle InteractionResponseDeferredChannelMessageWithSource in slash commands example. Also refactoring. Dec 3, 2021

FedorLap2006 approved these changes Dec 8, 2021

View reviewed changes

FedorLap2006 approved these changes Dec 28, 2021

View reviewed changes

FedorLap2006 requested changes Dec 28, 2021

View reviewed changes

telephrag closed this Apr 11, 2022

Integrated changes from #1129. Commands will be deleted even if panic…

74f086b

… occurs inside one of the handlers.

telephrag reopened this Apr 11, 2022

telephrag requested a review from FedorLap2006 April 14, 2022 11:00

FedorLap2006 requested changes Apr 14, 2022

View reviewed changes

telephrag added 2 commits April 15, 2022 18:36

Minor cleanup

176a7ae

Integrated #1125. Made use of ApplicationCommandBulkOverwrite. Improv…

a3a7e25

…ed panic handling.

telephrag requested a review from FedorLap2006 April 16, 2022 11:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Handle InteractionResponseDeferredChannelMessageWithSource in slash commands example. Also refactoring. #1045

fix: Handle InteractionResponseDeferredChannelMessageWithSource in slash commands example. Also refactoring. #1045

telephrag commented Dec 3, 2021 •

edited

FedorLap2006 left a comment

FedorLap2006 Dec 8, 2021

telephrag Dec 9, 2021

telephrag Dec 11, 2021

FedorLap2006 left a comment

FedorLap2006 Dec 28, 2021

FedorLap2006 commented Mar 23, 2022 •

edited

telephrag commented Mar 24, 2022

telephrag commented Apr 2, 2022

FedorLap2006 commented Apr 2, 2022

telephrag commented Apr 11, 2022

telephrag commented Apr 11, 2022

FedorLap2006 Apr 14, 2022

FedorLap2006 Apr 14, 2022

FedorLap2006 Apr 14, 2022

FedorLap2006 Apr 14, 2022

FedorLap2006 Apr 14, 2022

FedorLap2006 Apr 14, 2022 •

edited

FedorLap2006 Apr 14, 2022

FedorLap2006 Apr 14, 2022

FedorLap2006 Apr 14, 2022

FedorLap2006 Apr 14, 2022

FedorLap2006 commented Apr 14, 2022

		const GuildID string = "Bot token goes here"
		const BotToken string = "Guild where the bot will be used"

	r := recover()
	if r != nil {
	if err := recover(); err != nil {

	log.Fatal("Error occured inside command handler")
	log.Fatalf("Error occured inside command handler: %s", err)

		}

		func BasicWithFile(s discordgo.Session, i discordgo.InteractionCreate) {

		}

		func Subcommands(s discordgo.Session, i discordgo.InteractionCreate) {

		}

		func Responses(s discordgo.Session, i discordgo.InteractionCreate) {

fix: Handle InteractionResponseDeferredChannelMessageWithSource in slash commands example. Also refactoring. #1045

fix: Handle InteractionResponseDeferredChannelMessageWithSource in slash commands example. Also refactoring. #1045

Conversation

telephrag commented Dec 3, 2021 • edited

FedorLap2006 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FedorLap2006 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FedorLap2006 commented Mar 23, 2022 • edited

telephrag commented Mar 24, 2022

telephrag commented Apr 2, 2022

FedorLap2006 commented Apr 2, 2022

telephrag commented Apr 11, 2022

telephrag commented Apr 11, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FedorLap2006 Apr 14, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FedorLap2006 commented Apr 14, 2022

telephrag commented Dec 3, 2021 •

edited

FedorLap2006 commented Mar 23, 2022 •

edited

FedorLap2006 Apr 14, 2022 •

edited