Skip to content

Commit

Permalink
Cleanup linting workflow actions.
Browse files Browse the repository at this point in the history
- Fix go lint version.
- v3 of golint and remove the go-setup dependency: golangci/golangci-lint-action#403
- Make the checkout step in the linter match the release config.
  - Good to be consistent so it's easier to tell your linting will pass
    release.

Signed-off-by: Brendan Winter <bwinter@vmware.com>
  • Loading branch information
bwinter committed Jun 2, 2023
1 parent b45a379 commit 75bd8f2
Showing 1 changed file with 18 additions and 7 deletions.
25 changes: 18 additions & 7 deletions .github/workflows/golangci-lint.yml
@@ -1,17 +1,28 @@
name: golangci-lint

on:
push:
tags:
- v*
branches:
- master
pull_request:

jobs:
golangci:
name: lint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Checkout
uses: actions/checkout@v3
with:
fetch-depth: 0
- name: golangci-lint
uses: golangci/golangci-lint-action@v2
uses: golangci/golangci-lint-action@v3
with:
version: v2.5.2
skip-pkg-cache: true
skip-build-cache: true
args: --issues-exit-code=1
only-new-issues: true
# Required: the version of golangci-lint is required and must be specified without a patch version:
# we always use the latest patch version.
version: v1.52
# Optional: if set to `true` then the all caching functionality will be complete disabled,
# takes precedence over all other caching options.
skip-cache: true

0 comments on commit 75bd8f2

Please sign in to comment.