Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use 'registerChild' as ref in registerChild example #1814

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pinko-fowle
Copy link

@pinko-fowle pinko-fowle commented Mar 30, 2023

In the registerChild example in CellMeasurer, we never use registerChild. From looking around some, I believe one valid use is to pass it as ref={registerChild}, which I do here.

I'm still quite unsure of this PR but it seems to match most of the examples I've found. And the current state of the docs seems quite weird/confusing, as we introduce this param then don't use it. I hope this PR makes sense, & please forgive me if not.

One example of another user here following this pattern is this comment: #1572 (comment)

  • For any documentation changes, the text has been proofread and is clear to both experienced users and beginners.
  • Format your code with prettier (yarn run prettier).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants