Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1803 feat: ✨ add containerStyle to List Component #1804

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

october-rain
Copy link

Thanks for contributing to react-virtualized!

Before submitting a pull request, please complete the following checklist:

  • [ ✅ ] The existing test suites (npm test) all pass
  • [ ✅ ] For any new features or bug fixes, both positive and negative test cases have been added
  • [ ✅ ] For any new features, documentation has been added
  • [ ✅ ] For any documentation changes, the text has been proofread and is clear to both experienced users and beginners.
  • [ ✅ ] Format your code with prettier (yarn run prettier).
  • [ ✅ ] Run the Flow typechecks (yarn run typecheck).

Reason Of The New Feature

According to #1803 :
this bug is because of the Inner container of Grid Component, its position property value is 'relative'. And I use List Component which doesn't have containerStyle property like Grid Component as well.
so i think maybe we can offer containerStyle for List or change default position to 'static'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant