Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Feature: Footer row support in table #1710

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

venkateshsundaram
Copy link

@venkateshsundaram venkateshsundaram commented Nov 28, 2021

Thanks for contributing to react-virtualized!

Description

Supporting footer row in table for react-virtualized.

Before submitting a pull request, please complete the following checklist:

  • The existing test suites (npm test) all pass
  • For any new features or bug fixes, both positive and negative test cases have been added
  • For any new features, documentation has been added
  • For any documentation changes, the text has been proofread and is clear to both experienced users and beginners.
  • Format your code with prettier (yarn run prettier).
  • Run the Flow typechecks (yarn run typecheck).

Here is a short checklist of additional things to keep in mind before submitting:

  • Please make sure your pull request description makes it very clear what you're trying to accomplish. If it's a bug fix, please also provide a failing test case (if possible). In either case, please add additional unit test coverage for your changes. :)
  • Be sure you have notifications setup so that you'll see my code review responses. (I may ask you to make some adjustments before merging.)

Screenshots

Original Update
**
react-virtualized(before)** ** after 2 react-virtualized**

@venkateshsundaram
Copy link
Author

venkateshsundaram commented Nov 29, 2021

Footer row will work accordingly based on more rows(data with scroll) and less rows (data without scroll)

Real time Usage:

Footer.Row.Virtualized.mov

@venkateshsundaram venkateshsundaram changed the title Add Feature: Footer support Add Feature: Footer row support in table Nov 30, 2021
@venkateshsundaram
Copy link
Author

Hi @wuweiweiwu Can you pls help me to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant