Accessibility improvements for role on Table & Column components #1691
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We're seeing an issue that impacts multiple tables in our application. This is mostly on Windows computers and causes the screenreader to go into a different mode when tabbing into the
div
(this has role"grid"
and the columns have role"gridcell"
).role="grid"
triggers Application Mode for the Windows screenreader.Contribution Checklist
Thanks for contributing to react-virtualized!
Before submitting a pull request, please complete the following checklist:
npm test
) all passyarn run prettier
).yarn run typecheck
).Here is a short checklist of additional things to keep in mind before submitting: