Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility improvements for role on Table & Column components #1691

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

laughnan
Copy link

@laughnan laughnan commented Sep 10, 2021

Changes

We're seeing an issue that impacts multiple tables in our application. This is mostly on Windows computers and causes the screenreader to go into a different mode when tabbing into the div (this has role "grid" and the columns have role "gridcell").

  • On Windows, role="grid" triggers Application Mode for the Windows screenreader.
    • 90% of screenreader users are on Windows computers (importance of change)
    • Application mode passes all keystrokes to the browser
    • Visitors can no longer "read" the text as they're navigating the Table (which is effectively a grid).
  • This does not seem to be an issue on Apple with Voiceover.

Contribution Checklist

Thanks for contributing to react-virtualized!

Before submitting a pull request, please complete the following checklist:

  • The existing test suites (npm test) all pass
  • For any new features or bug fixes, both positive and negative test cases have been added
  • For any new features, documentation has been added
  • For any documentation changes, the text has been proofread and is clear to both experienced users and beginners.
  • Format your code with prettier (yarn run prettier).
  • Run the Flow typechecks (yarn run typecheck).

Here is a short checklist of additional things to keep in mind before submitting:

  • Please make sure your pull request description makes it very clear what you're trying to accomplish. If it's a bug fix, please also provide a failing test case (if possible). In either case, please add additional unit test coverage for your changes. :)
  • Be sure you have notifications setup so that you'll see my code review responses. (I may ask you to make some adjustments before merging.)

@laughnan
Copy link
Author

Creating this PR to support accessibility improvements noted in #1604

@laughnan
Copy link
Author

All initial tests in 429a472 pass (without new tests) showing that this change is backwards compatible.

@laughnan
Copy link
Author

Component testing

  1. Update role prop for Table and Column

Screen Shot 2021-09-09 at 19 25 39

  1. Confirmation of the UI rendering the right values

react-virtualized

@laughnan
Copy link
Author

@wuweiweiwu can you give this a review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant