Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.01 a11y #1646

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

1.01 a11y #1646

wants to merge 13 commits into from

Conversation

adirhaz1z
Copy link

Thanks for contributing to react-virtualized!

Before submitting a pull request, please complete the following checklist:

  • The existing test suites (npm test) all pass
  • For any new features or bug fixes, both positive and negative test cases have been added
  • For any new features, documentation has been added
  • For any documentation changes, the text has been proofread and is clear to both experienced users and beginners.
  • Format your code with prettier (yarn run prettier).
  • Run the Flow typechecks (yarn run typecheck).

Here is a short checklist of additional things to keep in mind before submitting:

  • Please make sure your pull request description makes it very clear what you're trying to accomplish. If it's a bug fix, please also provide a failing test case (if possible). In either case, please add additional unit test coverage for your changes. :)
  • Be sure you have notifications setup so that you'll see my code review responses. (I may ask you to make some adjustments before merging.)

@adirhaz1z adirhaz1z force-pushed the 1.01_a11y branch 2 times, most recently from 77f6742 to 0198128 Compare April 11, 2021 02:14
@wuweiweiwu
Copy link
Collaborator

hi! can you document what changes you are trying to make?

and also please revert the changes to .gitignore

@laughnan
Copy link

@wuweiweiwu I think this change is related to #1604 where we're looking for more customization in the role prop for the Table component. Maybe @adirhaz1z can confirm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants