Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Table): allow cell overflow style to be overridden #1424

Merged
merged 1 commit into from Oct 30, 2019
Merged

fix(Table): allow cell overflow style to be overridden #1424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion source/Table/Table.jest.js
View file
Open in desktop
Expand Up @@ -1099,7 +1099,7 @@ describe('Table', () => {
});

it('should use custom :styles if specified', () => {
const columnStyle = {backgroundColor: 'red'};
const columnStyle = {backgroundColor: 'red', overflow: 'visible'};
const headerStyle = {backgroundColor: 'blue'};
const columnHeaderStyle = {color: 'yellow'};
const rowStyle = {backgroundColor: 'green'};
Expand All @@ -1119,6 +1119,10 @@ describe('Table', () => {
node.querySelector('.ReactVirtualized__Table__rowColumn').style
.backgroundColor,
).toEqual('red');
expect(
node.querySelector('.ReactVirtualized__Table__rowColumn').style
.overflow,
).toEqual('visible');
expect(
node.querySelector('.ReactVirtualized__Table__headerColumn').style
.backgroundColor,
Expand Down
2 changes: 1 addition & 1 deletion source/Table/Table.js
View file
Open in desktop
Expand Up @@ -394,8 +394,8 @@ export default class Table extends React.PureComponent {
);

this._cachedColumnStyles[index] = {
...flexStyles,
overflow: 'hidden',
...flexStyles,
};
});

Expand Down